Feature/sign in screen #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 34fc230422f01e98a321b3caa7dfe3c9f20cf21b.
AdrienBousquieEPFL
requested changes
Oct 12, 2024
There was a problem hiding this comment.
You need to update the branch by merging it with the current state of the main branch and resolve the potential conflicts. By the way, I annotated some things that we can change and things that we can discuss to prepare for modularity with the dark mode. Otherwise, the tests and the code is fine 👍
app/src/main/java/com/github/lookupgroup27/lookup/ui/authentication/SignIn.kt
Outdated
Show resolved
Hide resolved
…kUp into feature/sign-in-screen
Added the possibility for the CI to actually use our google_services.json file using GitHub secrets
We will actually skip this for now and add an issue to actually fix this code coverage problem on the SignIn.kt file later. |
AdrienBousquieEPFL
requested review from
mehdi-hamirifou
and removed request for
mehdi-hamirifou
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the SignIn feature and adds UI tests for ensuring the functionality. It also integrates the Google Mobile Services (GMS) plugin in the app-level Gradle file to support Google Sign-In functionality.
Main changes:
Implemented the SignIn feature with Google authentication using Firebase.
Added UI tests to verify the correct behavior of the SignIn screen and Google Sign-In flow.
Integrated the GMS plugin in the app-level build.gradle file to enable Google authentication services.
Closes Issue:
Closes #17