Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement MainActivity with navigation setup #22

Merged
merged 24 commits into from
Oct 14, 2024

Conversation

Kenzoud
Copy link
Contributor

@Kenzoud Kenzoud commented Oct 11, 2024

This pull request introduces the setup for MainActivity to manage navigation across the app. It establishes a NavHost and defines the navigation flow for core screens, allowing for a structured, streamlined user experience.

Main changes:

  • Configured MainActivity with a NavHost and routes for primary screens.
  • Integrated NavigationActions to enable smooth transitions and proper navigation handling across screens.
  • Added BottomNavigationMenu for usage in specific screens for better navigation control.

Closes Issue:

Closes #20

@Kenzoud Kenzoud self-assigned this Oct 11, 2024
@Kenzoud
Copy link
Contributor Author

Kenzoud commented Oct 12, 2024

I’m holding off on merging this PR until other pending PRs are merged into main, as they contain changes that affect shared classes. Once those are merged, I’ll pull the latest main changes into this branch, resolve any conflicts, and push the updated branch before finalizing this merge.

@Kenzoud Kenzoud requested review from raniabbrk and AdrienBousquieEPFL and removed request for raniabbrk and AdrienBousquieEPFL October 14, 2024 11:58
Copy link
Contributor

@Ismaillat Ismaillat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks well implemented

@AdrienBousquieEPFL AdrienBousquieEPFL removed their request for review October 14, 2024 12:21
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
41.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@Kenzoud Kenzoud merged commit 0836ff6 into main Oct 14, 2024
1 of 2 checks passed
@Kenzoud Kenzoud deleted the feature/update-main-activity branch October 14, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement MainActivity with navigation setup
2 participants