Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Accommodate early morning, late night, and Saturday classes (Resolves #399) #438

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

adityamkk
Copy link
Contributor

@adityamkk adityamkk commented Nov 18, 2024

This PR resolves #399
Issue:
The calendar grid does not accommodate for early morning, late night, and Saturday courses, instead dumping them in the Async/Other category in the bottom bar.

Resolving the Issue:
I have redirected early morning, late night, and Saturday courses to the main calendar grid instead of the bottom bar.
I have made the calendar grid flexible: it grows larger to allow for early morning, late night, and Saturday courses, but shrinks back to standard size when the course is removed.

Early Morning Accommodation:
image

Late Night Accommodation:
image

Saturday Course Accommodation:
image


This change is Reviewable

Copy link
Member

@IsaDavRod IsaDavRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has some broken results upon opening calendar even while no late, early, or Saturday courses exist, and when they do exist. The height of y-axis hours are also inconsistent sometimes or the y-axis ticks do not align with the grid (this appears on your example screenshots).

Please resolve these issues and I can continue reviewing.

image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accommodate for early morning, late night and saturday courses in the Calendar grid
3 participants