Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Reth client to v1.1.1 #45

Closed
wants to merge 2 commits into from
Closed

Conversation

matjazv
Copy link

@matjazv matjazv commented Nov 6, 2024

What was the problem?

This PR resolves #LISK-1248.

How was it solved?

  • Update op-reth client to v1.1.1.
  • Remove --engine.experimental flag for op-reth client as experimental engine is default now and the --engine.experimental flag is deprecated.
  • Update README to reflect the update in the op-reth start command when running with the CLI.

How was it tested?

  • CLIENT=reth docker compose up --build --detach

@matjazv matjazv requested review from shuse2 and Incede November 6, 2024 08:06
@matjazv matjazv self-assigned this Nov 6, 2024
@sameersubudhi sameersubudhi requested review from sameersubudhi and removed request for shuse2 November 11, 2024 10:15
Copy link
Member

@sameersubudhi sameersubudhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the node multiple times and following warnings always recur in the op-node logs. Did you encounter this? These don't occur on the main branch though.

2024-11-11 23:04:59 t=2024-11-11T22:04:59+0000 lvl=info msg="Received signed execution payload from p2p" id=0xd4b1980ff702a65acef01e1be18af2406dae04be11ba9efea6f0658d149bb186:8316954 peer=16Uiu2HAmBuVpfZwoRodETmKQPiiE7awhs53vGaBzJCuZnSuU2zyb txs=1
2024-11-11 23:04:59 t=2024-11-11T22:04:59+0000 lvl=info msg="Optimistically queueing unsafe L2 execution payload" id=0xd4b1980ff702a65acef01e1be18af2406dae04be11ba9efea6f0658d149bb186:8316954
2024-11-11 23:05:01 t=2024-11-11T22:05:01+0000 lvl=warn msg="Failed to get payload" payload_id=0x036cceadd1e96b2d payload_id=0x036cceadd1e96b2d err="Unknown payload"
2024-11-11 23:05:01 t=2024-11-11T22:05:01+0000 lvl=warn msg="Cannot seal block, payload ID is unknown" payloadID=0x036cceadd1e96b2d payload_time=1714728793 started_time=2024-11-11T22:05:01+0000
2024-11-11 23:05:01 t=2024-11-11T22:05:01+0000 lvl=warn msg="Block sealing job of derived attributes expired, job will be re-attempted." build_id=0x036cceadd1e96b2d timestamp=1714728793 err="failed to seal execution payload (ID: 0x036cceadd1e96b2d): input error -38001: Unknown payload"
2024-11-11 23:05:01 t=2024-11-11T22:05:01+0000 lvl=info msg="Received signed execution payload from p2p" id=0xa4bcb8feafb55669d10bd01f534883eb3d018c35b0f6d6f9d005c62a0ab6f612:8316955 peer=16Uiu2HAmBuVpfZwoRodETmKQPiiE7awhs53vGaBzJCuZnSuU2zyb txs=1
2024-11-11 23:05:01 t=2024-11-11T22:05:01+0000 lvl=info msg="Optimistically queueing unsafe L2 execution payload" id=0xa4bcb8feafb55669d10bd01f534883eb3d018c35b0f6d6f9d005c62a0ab6f612:8316955
2024-11-11 23:05:04 t=2024-11-11T22:05:04+0000 lvl=info msg="Received signed execution payload from p2p" id=0xb002b9adc0d752d7f51a31f433e4a91cdbf54ea51c214355828b387b94825db5:8316956 peer=16Uiu2HAmBuVpfZwoRodETmKQPiiE7awhs53vGaBzJCuZnSuU2zyb txs=1
2024-11-11 23:05:04 t=2024-11-11T22:05:04+0000 lvl=info msg="Optimistically queueing unsafe L2 execution payload" id=0xb002b9adc0d752d7f51a31f433e4a91cdbf54ea51c214355828b387b94825db5:8316956

@matjazv
Copy link
Author

matjazv commented Nov 12, 2024

I ran the node multiple times and following warnings always recur in the op-node logs. Did you encounter this? These don't occur on the main branch though.

2024-11-11 23:04:59 t=2024-11-11T22:04:59+0000 lvl=info msg="Received signed execution payload from p2p" id=0xd4b1980ff702a65acef01e1be18af2406dae04be11ba9efea6f0658d149bb186:8316954 peer=16Uiu2HAmBuVpfZwoRodETmKQPiiE7awhs53vGaBzJCuZnSuU2zyb txs=1
2024-11-11 23:04:59 t=2024-11-11T22:04:59+0000 lvl=info msg="Optimistically queueing unsafe L2 execution payload" id=0xd4b1980ff702a65acef01e1be18af2406dae04be11ba9efea6f0658d149bb186:8316954
2024-11-11 23:05:01 t=2024-11-11T22:05:01+0000 lvl=warn msg="Failed to get payload" payload_id=0x036cceadd1e96b2d payload_id=0x036cceadd1e96b2d err="Unknown payload"
2024-11-11 23:05:01 t=2024-11-11T22:05:01+0000 lvl=warn msg="Cannot seal block, payload ID is unknown" payloadID=0x036cceadd1e96b2d payload_time=1714728793 started_time=2024-11-11T22:05:01+0000
2024-11-11 23:05:01 t=2024-11-11T22:05:01+0000 lvl=warn msg="Block sealing job of derived attributes expired, job will be re-attempted." build_id=0x036cceadd1e96b2d timestamp=1714728793 err="failed to seal execution payload (ID: 0x036cceadd1e96b2d): input error -38001: Unknown payload"
2024-11-11 23:05:01 t=2024-11-11T22:05:01+0000 lvl=info msg="Received signed execution payload from p2p" id=0xa4bcb8feafb55669d10bd01f534883eb3d018c35b0f6d6f9d005c62a0ab6f612:8316955 peer=16Uiu2HAmBuVpfZwoRodETmKQPiiE7awhs53vGaBzJCuZnSuU2zyb txs=1
2024-11-11 23:05:01 t=2024-11-11T22:05:01+0000 lvl=info msg="Optimistically queueing unsafe L2 execution payload" id=0xa4bcb8feafb55669d10bd01f534883eb3d018c35b0f6d6f9d005c62a0ab6f612:8316955
2024-11-11 23:05:04 t=2024-11-11T22:05:04+0000 lvl=info msg="Received signed execution payload from p2p" id=0xb002b9adc0d752d7f51a31f433e4a91cdbf54ea51c214355828b387b94825db5:8316956 peer=16Uiu2HAmBuVpfZwoRodETmKQPiiE7awhs53vGaBzJCuZnSuU2zyb txs=1
2024-11-11 23:05:04 t=2024-11-11T22:05:04+0000 lvl=info msg="Optimistically queueing unsafe L2 execution payload" id=0xb002b9adc0d752d7f51a31f433e4a91cdbf54ea51c214355828b387b94825db5:8316956

Yes, I have noticed those messages recently.
We could try using the new OP Stack v1.9.5 version to see if these messages continue to appear.

@matjazv
Copy link
Author

matjazv commented Nov 13, 2024

I ran the node multiple times and following warnings always recur in the op-node logs. Did you encounter this? These don't occur on the main branch though.

2024-11-11 23:04:59 t=2024-11-11T22:04:59+0000 lvl=info msg="Received signed execution payload from p2p" id=0xd4b1980ff702a65acef01e1be18af2406dae04be11ba9efea6f0658d149bb186:8316954 peer=16Uiu2HAmBuVpfZwoRodETmKQPiiE7awhs53vGaBzJCuZnSuU2zyb txs=1
2024-11-11 23:04:59 t=2024-11-11T22:04:59+0000 lvl=info msg="Optimistically queueing unsafe L2 execution payload" id=0xd4b1980ff702a65acef01e1be18af2406dae04be11ba9efea6f0658d149bb186:8316954
2024-11-11 23:05:01 t=2024-11-11T22:05:01+0000 lvl=warn msg="Failed to get payload" payload_id=0x036cceadd1e96b2d payload_id=0x036cceadd1e96b2d err="Unknown payload"
2024-11-11 23:05:01 t=2024-11-11T22:05:01+0000 lvl=warn msg="Cannot seal block, payload ID is unknown" payloadID=0x036cceadd1e96b2d payload_time=1714728793 started_time=2024-11-11T22:05:01+0000
2024-11-11 23:05:01 t=2024-11-11T22:05:01+0000 lvl=warn msg="Block sealing job of derived attributes expired, job will be re-attempted." build_id=0x036cceadd1e96b2d timestamp=1714728793 err="failed to seal execution payload (ID: 0x036cceadd1e96b2d): input error -38001: Unknown payload"
2024-11-11 23:05:01 t=2024-11-11T22:05:01+0000 lvl=info msg="Received signed execution payload from p2p" id=0xa4bcb8feafb55669d10bd01f534883eb3d018c35b0f6d6f9d005c62a0ab6f612:8316955 peer=16Uiu2HAmBuVpfZwoRodETmKQPiiE7awhs53vGaBzJCuZnSuU2zyb txs=1
2024-11-11 23:05:01 t=2024-11-11T22:05:01+0000 lvl=info msg="Optimistically queueing unsafe L2 execution payload" id=0xa4bcb8feafb55669d10bd01f534883eb3d018c35b0f6d6f9d005c62a0ab6f612:8316955
2024-11-11 23:05:04 t=2024-11-11T22:05:04+0000 lvl=info msg="Received signed execution payload from p2p" id=0xb002b9adc0d752d7f51a31f433e4a91cdbf54ea51c214355828b387b94825db5:8316956 peer=16Uiu2HAmBuVpfZwoRodETmKQPiiE7awhs53vGaBzJCuZnSuU2zyb txs=1
2024-11-11 23:05:04 t=2024-11-11T22:05:04+0000 lvl=info msg="Optimistically queueing unsafe L2 execution payload" id=0xb002b9adc0d752d7f51a31f433e4a91cdbf54ea51c214355828b387b94825db5:8316956

Related issues:

@matjazv matjazv force-pushed the LISK-1248-Update-Reth-to-v1.1.1 branch from e8aec07 to e491fbd Compare November 13, 2024 08:17
@matjazv
Copy link
Author

matjazv commented Nov 13, 2024

Response from Reth team:

somehow we never Hit this on our infra...
sorry about this, expediting new release with fix https://github.com/paradigmxyz/reth/pull/12520 in the meantime please use 1.1.0
expect 1.1.2 monday

So on Monday we should get a new Reth version with a fixed issue.

@sameersubudhi
Copy link
Member

Skipping reth upgrade to v1.1.1 based on this comment from the reth dev team. Closing the issue.

thanks for flagging,
somehow we never Hit this on our infra...
sorry about this, expediting new release with fix paradigmxyz/reth#12520 in the meantime please use 1.1.0

@sameersubudhi sameersubudhi deleted the LISK-1248-Update-Reth-to-v1.1.1 branch November 13, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants