Sync with upstream repo #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This will be used to limit the fill size on testnet in order to preserve the relayer's token balance.
…#1967) Signed-off-by: bennett <[email protected]> Co-authored-by: Paul <[email protected]>
* fix: sepolia bridge definitions Signed-off-by: bennett <[email protected]> --------- Signed-off-by: bennett <[email protected]>
* fix(Dataworker): Cannot fund DonationBox using MulticallerClient The MulticallerClient has [logic](https://github.com/across-protocol/relayer/blob/40b0c7971a3548a0499e7fc5990d150437c527fb/src/clients/MultiCallerClient.ts#L361) that batches transactions together and attempts to `multicall()` them. This works normally with the `HubPool` and `SpokePool` which extend the `Multicaller()` interface. However, we can't use this logic to make calls on ERC20's like we are doing to fund the `DonationBox`. Instead, we either need to update the `MulticallerClient` to handle cases where transactions are not multicall-able, or we can send these transactions to the `TransactionClient`. In this PR, I added a new method `simulateAndSubmit` to the `TransactionClient` that the Dataworker uses to `transfer` custom gas tokens to the DonationBox. * Update src/dataworker/Dataworker.ts * Update Dataworker.executePoolRebalanceUtils.ts * Update TransactionClient.ts * Update TransactionClient.ts * Update src/clients/TransactionClient.ts Co-authored-by: James Morris, MS <[email protected]> * Use Multicaller client * Consolidate valueTxnsand nonMulticallTxns * Update MultiCallerClient.ts * Update MultiCallerClient.ts --------- Co-authored-by: James Morris, MS <[email protected]>
…1969) * improve(TransactionUtils): Use base fee multiplier Builds on across-protocol/sdk#801 and applies relayer's base fee multiplier to new SDK parameter to scale the base fee * Update TransactionUtils.ts * Add unsignedTx to getGasPriceEstimate call in TransactionUtils `runTransaction` method * Add warning * Use baseFeeMultiplier in ProfitClient * Remove relayer specific gas padding, add unit test about relayer fee calculator call * Fix test * Revert changes to ProfitClient * Update TransactionUtils.ts * import sdk * 3.4.1 * 3.4.2 * 3.4.3 * Update logs * Update ProfitClient.ts * Update TransactionUtils.ts * Update package.json * Update yarn.lock * Update TransactionUtils.ts * Update TransactionUtils.ts * Update package.json * 3.4.5-beta.1 * 3.4.5
This is incorrectly dereferencing the `unprofitableDeposits` object, which is type `{ chainId: UnprofitableFill[] }`
Separately, the `depositMrkdwn` doesn't render well unless I put the ternary inside a ${} syntax
…ty log (#1990) * improve(Relayer): Add information about message size to unprofitability log Also, send warning about failure to estimate gas costs for deposit to a different slack channel than "unprofitable fills". We should isolate across-unprofitable-fills channel to only include messages for deposits that are unprofitable. The developer should then go to across-warn to figure * Update Relayer.ts * Update Relayer.ts * fix(Relayer): Fix unprofitable deposit log This is incorrectly dereferencing the `unprofitableDeposits` object, which is type `{ chainId: UnprofitableFill[] }` Separately, the `depositMrkdwn` doesn't render well unless I put the ternary inside a ${} syntax * Update Relayer.ts * Update Relayer.ts * Update Relayer.ts * Update Relayer.ts * Update Relayer.ts * Update Relayer.ts
Signed-off-by: bennett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge latest changes from upstream repo