Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Lisk core config directory not included in binary builds #198

Merged

Conversation

sameersubudhi
Copy link
Contributor

@sameersubudhi sameersubudhi commented Nov 1, 2023

What was the problem?

This PR resolves #197

How was it solved?

  • Move 'config' directory into 'src'
  • Added exclusive flag to network for the following:
    • lisk-core-v3-data-path
    • config
    • auto-migrate-config
    • auto-start-lisk-core-v4

How was it tested?

Locally against the mainnet

  • ./bin/run --snapshot-height 23097750 --auto-migrate-config --auto-start-lisk-core-v4

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #198 (926ac70) into release/2.0.0 (18c5964) will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/2.0.0     #198   +/-   ##
==============================================
  Coverage          82.08%   82.08%           
==============================================
  Files                 25       25           
  Lines                815      815           
  Branches             117      117           
==============================================
  Hits                 669      669           
  Misses               146      146           
Files Coverage Δ
src/utils/node.ts 43.96% <33.33%> (ø)

@sameersubudhi sameersubudhi force-pushed the 197-move-the-lisk-core-config-directory-to-src branch from 066b0ac to 9180449 Compare November 1, 2023 10:37
Copy link
Contributor

@nagdahimanshu nagdahimanshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sameersubudhi sameersubudhi merged commit 23d7bef into release/2.0.0 Nov 1, 2023
5 of 6 checks passed
@sameersubudhi sameersubudhi deleted the 197-move-the-lisk-core-config-directory-to-src branch November 1, 2023 11:10
@sameersubudhi sameersubudhi changed the title Move the lisk core config directory to src Lisk core config directory not included in binary builds Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants