Skip to content

Commit

Permalink
Fix update attributes ( close #90) (#91)
Browse files Browse the repository at this point in the history
* improve example for testing updateAttribtutes

* Fix updateAttributes bug

(Fix #90)
* change `utils/extractAttributes` to generate a vnode-compatible data object
* remove `utils/updateAttributes` method and references in hooks and methods
* make `this.attributes` return an empty object by default
* fix `noWrapper` computed prop which relied in `!this.attributes`
* fix render function to spread `this.attributes` it onto the root element

* 1.2.1-beta.1

* bump version
  • Loading branch information
LinusBorg authored Dec 12, 2017
1 parent 98a4b93 commit a2370cc
Show file tree
Hide file tree
Showing 8 changed files with 43 additions and 60 deletions.
48 changes: 21 additions & 27 deletions dist/portal-vue.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/portal-vue.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/portal-vue.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion example/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ <h4>The following content is outside of the control of the Vue main instance</h4
<p>But we can render stuff here nonetheless with the <i>mountTarget</i> Prop</p>
<div class="wrapper">
<div class="item destination">
<div id="external-target" class="test-external-target">
<div id="external-target" class="test-external-target" style="border: 1px solid grey;">
</div>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "portal-vue",
"version": "1.2.0",
"version": "1.2.1",
"description": "A Vue component to render elements outside of a component's template, elsewhere in the DOM",
"main": "dist/portal-vue.js",
"files": [
Expand Down
Loading

0 comments on commit a2370cc

Please sign in to comment.