Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Disable external dependencies for local dev #496

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bgins
Copy link
Contributor

@bgins bgins commented Jan 23, 2025

Summary

This pull request makes the following changes:

  • Disable API calls in local development
  • Disable telemetry in local development

The API and telemetry should not be required by default for local development, but they can be enabled when integrating with them.

Test plan

Check that the instructions in https://github.com/Lilypad-Tech/lilypad/blob/main/LOCAL_DEVELOPMENT.md work without running the API or observability servers.

Details

The API and telemetry can be enabled in local development.

Enable API calls by setting the --api-host CLI option. For example:

./stack solver --api-host http://localhost:8002/

Enable telemetry by setting the --disable-telemetry CLI option to false. For example:

./stack resource-provider --disable-telemetry=false

@bgins bgins requested a review from a team as a code owner January 23, 2025 17:25
@cla-bot cla-bot bot added the cla-signed label Jan 23, 2025
@github-actions github-actions bot added the chore label Jan 23, 2025
Copy link
Collaborator

@walkah walkah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected locally! 👍

@bgins bgins self-assigned this Jan 23, 2025
@PBillingsby
Copy link
Contributor

Works like a charm @bgins !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants