Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding unit tests for FoxgloveWebSocketPlayer module #335

Merged
merged 8 commits into from
Feb 4, 2025
Merged

Adding unit tests for FoxgloveWebSocketPlayer module #335

merged 8 commits into from
Feb 4, 2025

Conversation

ctw-joao-luis
Copy link
Contributor

@ctw-joao-luis ctw-joao-luis commented Jan 23, 2025 •
edited
Loading

User-Facing Changes
N/A

Description

Added some unit tests to files that provide support for the WebSocket player, also did some refactoring on the module.
Couldn't finish testing the whole module because I was having trouble accessing private fields and methods of the websocket class.

Checklist

  • The web version was tested and it is running ok
  • The desktop version was tested and it is running ok
  • This change is covered by unit tests
  • Files constants.ts, types.ts and *.style.ts have been checked and relevant code snippets have been relocated

@ctw-joao-luis ctw-joao-luis added the enhancement New feature or request label Jan 23, 2025
@ctw-joao-luis ctw-joao-luis marked this pull request as ready for review January 29, 2025 10:37
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ctw-joao-luis ctw-joao-luis merged commit e61f721 into main Feb 4, 2025
11 checks passed
@ctw-joao-luis ctw-joao-luis deleted the testing/FoxgloveWebSocketPlayer-unit-tests branch February 4, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aneuwald-ctw aneuwald-ctw aneuwald-ctw approved these changes

@luluiz luluiz luluiz approved these changes

@gabriela-almeida-ctw gabriela-almeida-ctw Awaiting requested review from gabriela-almeida-ctw

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ctw-joao-luis @luluiz @aneuwald-ctw @gabriela-almeida-ctw @laisspportugal