Update game addons... for Christmas! #9581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A quick build test of the addons (Generic) Need to revert b7fc8f5 for game.libretro.scummvm Unable to build test game.libretro.tyrquake - my dev environment is gcc-15 at the moment (and game.libretro.tyrquake doesn’t build with gcc-15.) |
|
I'll look into stella. I know that for Kodi's CI, it currently only builds on Windows, due to needing C++20. Lets drop the scummvm patch, I'm still working on that: #9083 I'll also look into tyrquake. |
|
the addition of these 2 commits allow all to build |
|
I've confirmed that all add-ons build against LE master now after adding your patches, including Tyrquake (LE master using gcc version 14.2.0) |
chewitt
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I had some time over the holiday break to do a round of game add-on updates. Besides rebasing everything on their master branches, not much has changed, except that the "Settings" button in the Advanced Settings is now using Kodi's localized "General" label: kodi-game/kodi-game-scripting#132
How has this been tested?
My build machine is in pieces on the floor, so I'm not able to compile-test this PR. But all add-ons have been run through Kodi's CI.