Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remaining DSNP 1.3 items and schemaIds #57

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Add remaining DSNP 1.3 items and schemaIds #57

merged 3 commits into from
Sep 27, 2024

Conversation

wesbiggs
Copy link
Member

@wesbiggs wesbiggs commented Sep 18, 2024

Note: cli scripts read.ts and find.ts are in api-augment limbo and won't lint/compile.

[Fixed]

Note: cli scripts read.ts and find.ts are in api-augment limbo and won't lint/compile
@wesbiggs wesbiggs requested a review from wilwade September 25, 2024 17:52
Copy link
Member

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

One non-blocking future question: How do want to remove the docker image entirely? Or perhaps just have the deploy script skip ones that are already in the base?

@wesbiggs wesbiggs merged commit 8bf3101 into main Sep 27, 2024
1 check passed
@wesbiggs wesbiggs deleted the task/dsnp-1.3 branch September 27, 2024 20:14
@wesbiggs
Copy link
Member Author

One non-blocking future question: How do want to remove the docker image entirely? Or perhaps just have the deploy script skip ones that are already in the base?

I think we can remove it entirely in favor of https://hub.docker.com/r/frequencychain/standalone-node and friends, given that deployed DSNP schema will be present at genesis there. I'll open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants