feat: linter + apply lint

LezdCS · Nov 21, 2024 · 66129aa · 66129aa
1 parent 11bbdb3
commit 66129aa
Show file tree

Hide file tree

Showing 92 changed files with 674 additions and 557 deletions.
diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -12,22 +12,225 @@ include: package:flutter_lints/flutter.yaml
 analyzer:
   errors:
     invalid_annotation_target: ignore
+  exclude:
+    - '**.freezed.dart'
+    - '**.g.dart'
+    - '**.gr.dart'
+    - '**/generated_plugin_registrant.dart'
 
 linter:
-  # The lint rules applied to this project can be customized in the
-  # section below to disable rules from the `package:flutter_lints/flutter.yaml`
-  # included above or to enable additional rules. A list of all available lints
-  # and their documentation is published at
-  # https://dart-lang.github.io/linter/lints/index.html.
-  #
-  # Instead of disabling a lint rule for the entire project in the
-  # section below, it can also be suppressed for a single line of code
-  # or a specific dart file by using the `// ignore: name_of_lint` and
-  # `// ignore_for_file: name_of_lint` syntax on the line or in the file
-  # producing the lint.
   rules:
-    # avoid_print: false  # Uncomment to disable the `avoid_print` rule
-    # prefer_single_quotes: true  # Uncomment to enable the `prefer_single_quotes` rule
-
-# Additional information about this file can be found at
-# https://dart.dev/guides/language/analysis-options
+    # - always_declare_return_types
+    - always_put_control_body_on_new_line
+    # - always_put_required_named_parameters_first
+    # - always_specify_types
+    - always_use_package_imports
+    - annotate_overrides
+    - annotate_redeclares
+    - avoid_annotating_with_dynamic
+    - avoid_bool_literals_in_conditional_expressions
+    # - avoid_catches_without_on_clauses
+    - avoid_catching_errors
+    - avoid_classes_with_only_static_members
+    - avoid_double_and_int_checks
+    # - avoid_dynamic_calls
+    - avoid_empty_else
+    - avoid_equals_and_hash_code_on_mutable_classes
+    - avoid_escaping_inner_quotes
+    - avoid_field_initializers_in_const_classes
+    - avoid_final_parameters
+    - avoid_function_literals_in_foreach_calls
+    - avoid_implementing_value_types
+    - avoid_init_to_null
+    - avoid_js_rounded_ints
+    - avoid_multiple_declarations_per_line
+    - avoid_null_checks_in_equality_operators
+    - avoid_positional_boolean_parameters
+    - avoid_print
+    - avoid_private_typedef_functions
+    - avoid_redundant_argument_values
+    - avoid_relative_lib_imports
+    - avoid_renaming_method_parameters
+    - avoid_return_types_on_setters
+    - avoid_returning_null_for_void
+    - avoid_returning_this
+    - avoid_setters_without_getters
+    - avoid_shadowing_type_parameters
+    - avoid_single_cascade_in_expression_statements
+    - avoid_slow_async_io
+    - avoid_type_to_string
+    - avoid_types_as_parameter_names
+    - avoid_unnecessary_containers
+    - avoid_unused_constructor_parameters
+    # - avoid_void_async
+    - avoid_web_libraries_in_flutter
+    - await_only_futures
+    - camel_case_extensions
+    - camel_case_types
+    - cancel_subscriptions
+    - cascade_invocations
+    # - cast_nullable_to_non_nullable
+    - close_sinks
+    - collection_methods_unrelated_type
+    - combinators_ordering
+    - comment_references
+    - conditional_uri_does_not_exist
+    - constant_identifier_names
+    - control_flow_in_finally
+    - curly_braces_in_flow_control_structures
+    - dangling_library_doc_comments
+    - depend_on_referenced_packages
+    - deprecated_consistency
+    - deprecated_member_use_from_same_package
+    # - diagnostic_describe_all_properties
+    - directives_ordering
+    # - discarded_futures
+    - do_not_use_environment
+    - document_ignores
+    - empty_catches
+    - empty_constructor_bodies
+    - empty_statements
+    - eol_at_end_of_file
+    - exhaustive_cases
+    - file_names
+    - flutter_style_todos
+    - hash_and_equals
+    - implementation_imports
+    - implicit_call_tearoffs
+    - implicit_reopen
+    - invalid_case_patterns
+    - invalid_runtime_check_with_js_interop_types
+    - join_return_with_assignment
+    - leading_newlines_in_multiline_strings
+    - library_annotations
+    - library_names
+    - library_prefixes
+    - library_private_types_in_public_api
+    - lines_longer_than_80_chars
+    - literal_only_boolean_expressions
+    - matching_super_parameters
+    - missing_code_block_language_in_doc_comment
+    - missing_whitespace_between_adjacent_strings
+    - no_adjacent_strings_in_list
+    # - no_default_cases
+    - no_duplicate_case_values
+    - no_leading_underscores_for_library_prefixes
+    - no_leading_underscores_for_local_identifiers
+    - no_literal_bool_comparisons
+    - no_logic_in_create_state
+    - no_runtimeType_toString
+    - no_self_assignments
+    - no_wildcard_variable_uses
+    - non_constant_identifier_names
+    - noop_primitive_operations
+    - null_check_on_nullable_type_parameter
+    - null_closures
+    - one_member_abstracts
+    - only_throw_errors
+    - overridden_fields
+    - package_api_docs
+    - package_names
+    - package_prefixed_library_names
+    - parameter_assignments
+    - prefer_adjacent_string_concatenation
+    - prefer_asserts_in_initializer_lists
+    - prefer_asserts_with_message
+    - prefer_collection_literals
+    - prefer_conditional_assignment
+    - prefer_const_constructors
+    - prefer_const_constructors_in_immutables
+    - prefer_const_declarations
+    - prefer_const_literals_to_create_immutables
+    - prefer_constructors_over_static_methods
+    - prefer_contains
+    # - prefer_expression_function_bodies
+    # - prefer_final_fields
+    # - prefer_final_in_for_each
+    # - prefer_final_locals
+    - prefer_for_elements_to_map_fromIterable
+    - prefer_foreach
+    - prefer_function_declarations_over_variables
+    - prefer_generic_function_type_aliases
+    - prefer_if_elements_to_conditional_expressions
+    - prefer_if_null_operators
+    - prefer_initializing_formals
+    - prefer_inlined_adds
+    - prefer_int_literals
+    - prefer_interpolation_to_compose_strings
+    - prefer_is_empty
+    - prefer_is_not_empty
+    - prefer_is_not_operator
+    - prefer_iterable_whereType
+    - prefer_mixin
+    - prefer_null_aware_method_calls
+    - prefer_null_aware_operators
+    - prefer_spread_collections
+    - prefer_typing_uninitialized_variables
+    - prefer_void_to_null
+    - provide_deprecation_message
+    # - public_member_api_docs
+    - recursive_getters
+    - require_trailing_commas
+    - secure_pubspec_urls
+    - sized_box_for_whitespace
+    - sized_box_shrink_expand
+    - slash_for_doc_comments
+    - sort_child_properties_last
+    # - sort_constructors_first
+    - sort_pub_dependencies
+    - sort_unnamed_constructors_first
+    - test_types_in_equals
+    - throw_in_finally
+    - tighten_type_of_initializing_formals
+    - type_annotate_public_apis
+    - type_init_formals
+    - type_literal_in_constant_pattern
+    # - unawaited_futures
+    - unintended_html_in_doc_comment
+    - unnecessary_await_in_return
+    - unnecessary_brace_in_string_interps
+    - unnecessary_breaks
+    - unnecessary_const
+    - unnecessary_constructor_name
+    - unnecessary_getters_setters
+    # - unnecessary_lambdas
+    - unnecessary_late
+    - unnecessary_library_directive
+    - unnecessary_library_name
+    - unnecessary_new
+    - unnecessary_null_aware_assignments
+    - unnecessary_null_aware_operator_on_extension_on_nullable
+    - unnecessary_null_checks
+    - unnecessary_null_in_if_null_operators
+    - unnecessary_nullable_for_final_variable_declarations
+    - unnecessary_overrides
+    - unnecessary_parenthesis
+    - unnecessary_raw_strings
+    - unnecessary_statements
+    - unnecessary_string_escapes
+    - unnecessary_string_interpolations
+    - unnecessary_this
+    - unnecessary_to_list_in_spreads
+    - unreachable_from_main
+    - unrelated_type_equality_checks
+    - use_build_context_synchronously
+    - use_colored_box
+    - use_decorated_box
+    - use_enums
+    - use_full_hex_values_for_flutter_colors
+    - use_function_type_syntax_for_parameters
+    - use_if_null_to_convert_nulls_to_bools
+    - use_is_even_rather_than_modulo
+    - use_key_in_widget_constructors
+    - use_late_for_private_fields_and_variables
+    - use_named_constants
+    - use_raw_strings
+    - use_rethrow_when_possible
+    - use_setters_to_change_properties
+    - use_string_buffers
+    - use_string_in_part_of_directives
+    - use_super_parameters
+    - use_test_throws_matchers
+    - use_to_and_as_if_applicable
+    - valid_regexps
+    - void_checks
diff --git a/lib/firebase_options.dart b/lib/firebase_options.dart
@@ -2,7 +2,7 @@
 // ignore_for_file: lines_longer_than_80_chars, avoid_classes_with_only_static_members
 import 'package:firebase_core/firebase_core.dart' show FirebaseOptions;
 import 'package:flutter/foundation.dart'
-    show defaultTargetPlatform, kIsWeb, TargetPlatform;
+    show TargetPlatform, defaultTargetPlatform, kIsWeb;
 
 /// Default [FirebaseOptions] for use with your Firebase apps.
 ///

diff --git a/lib/src/bindings/home_bindings.dart b/lib/src/bindings/home_bindings.dart
@@ -48,29 +48,29 @@ class HomeBindings extends Bindings {
     final setChatSettingsUseCase = SetChatSettingsUseCase(twitchRepository);
     final setStreamTitleUseCase = SetStreamTitleUseCase(twitchRepository);
     final getOverlaysUseCase = StreamElementsGetOverlaysUseCase(
-        streamelementsRepository: streamelementsRepository);
+        streamelementsRepository: streamelementsRepository,);
     final getMeUseCase = StreamElementsGetMeUseCase(
-        streamelementsRepository: streamelementsRepository);
+        streamelementsRepository: streamelementsRepository,);
     final getLocalCredentialsUseCase = StreamElementsGetLocalCredentialsUseCase(
-        streamelementsRepository: streamelementsRepository);
+        streamelementsRepository: streamelementsRepository,);
     final refreshTokenUseCase = StreamElementsRefreshTokenUseCase(
-        streamelementsRepository: streamelementsRepository);
+        streamelementsRepository: streamelementsRepository,);
     final replayActivityUseCase = StreamElementsReplayActivityUseCase(
-        streamelementsRepository: streamelementsRepository);
+        streamelementsRepository: streamelementsRepository,);
     final nextSongUseCase = StreamElementsNextSongUseCase(
-        streamelementsRepository: streamelementsRepository);
+        streamelementsRepository: streamelementsRepository,);
     final removeSongUseCase = StreamElementsRemoveSongUseCase(
-        streamelementsRepository: streamelementsRepository);
+        streamelementsRepository: streamelementsRepository,);
     final resetQueueUseCase = StreamElementsResetQueueUseCase(
-        streamelementsRepository: streamelementsRepository);
+        streamelementsRepository: streamelementsRepository,);
     final updatePlayerStateUseCase = StreamElementsUpdatePlayerStateUseCase(
-        streamelementsRepository: streamelementsRepository);
+        streamelementsRepository: streamelementsRepository,);
     final getLastActivitiesUseCase = StreamElementsGetLastActivitiesUseCase(
-        streamelementsRepository: streamelementsRepository);
+        streamelementsRepository: streamelementsRepository,);
     final getSongPlayingUseCase = StreamElementsGetSongPlayingUseCase(
-        streamelementsRepository: streamelementsRepository);
+        streamelementsRepository: streamelementsRepository,);
     final getSongQueueUseCase = StreamElementsGetSongQueueUseCase(
-        streamelementsRepository: streamelementsRepository);
+        streamelementsRepository: streamelementsRepository,);
 
     Get.lazyPut<HomeViewController>(
       () => HomeViewController(
@@ -125,7 +125,7 @@ class HomeBindings extends Bindings {
               homeViewController: Get.find<HomeViewController>(),
               settingsService: settingsService,
             ),
-        fenix: true);
+        fenix: true,);
     Get.lazyPut<RealtimeIrlViewController>(
       () => RealtimeIrlViewController(),
       fenix: true,

diff --git a/lib/src/bindings/settings_bindings.dart b/lib/src/bindings/settings_bindings.dart
@@ -26,10 +26,10 @@ class SettingsBindings extends Bindings {
     LogoutUseCase logoutUseCase = LogoutUseCase(twitchRepository);
     StreamElementsLoginUseCase streamElementsLoginUseCase =
         StreamElementsLoginUseCase(
-            streamelementsRepository: streamelementsRepository);
+            streamelementsRepository: streamelementsRepository,);
     StreamElementsDisconnectUseCase streamElementsDisconnectUseCase =
         StreamElementsDisconnectUseCase(
-            streamelementsRepository: streamelementsRepository);
+            streamelementsRepository: streamelementsRepository,);
 
     Get.lazyPut<SettingsViewController>(
       () => SettingsViewController(

diff --git a/lib/src/core/resources/themes.dart b/lib/src/core/resources/themes.dart
@@ -159,7 +159,7 @@ class Themes {
     primaryIconTheme: const IconThemeData(color: Colors.black),
     inputDecorationTheme: InputDecorationTheme(
       border: const OutlineInputBorder(
-        borderSide: BorderSide(color: Colors.black),
+
       ),
       helperStyle: const TextStyle(
         color: Color.fromARGB(255, 28, 25, 25),
@@ -233,7 +233,7 @@ class Themes {
         color: Colors.black,
       ),
       side: const BorderSide(
-        color: Colors.black,
+
       ),
       disabledColor: const Color(0xFF18181b),
       selectedColor: Colors.deepPurpleAccent[200],
@@ -277,7 +277,7 @@ class Themes {
     ),
     checkboxTheme: CheckboxThemeData(
       side: const BorderSide(
-        color: Colors.black,
+
       ),
       checkColor: WidgetStateProperty.all(Colors.deepPurple[600]),
     ),

diff --git a/lib/src/core/services/realtime_irl.dart b/lib/src/core/services/realtime_irl.dart
@@ -28,7 +28,7 @@ class RealtimeIrl {
     this.key,
   );
 
-  Future<void> onReceiveTaskData(dynamic data) async {
+  Future<void> onReceiveTaskData(data) async {
     if (data is Map<String, dynamic>) {
       final dynamic action = data["action"];
       switch (action) {

diff --git a/lib/src/core/services/settings_service.dart b/lib/src/core/services/settings_service.dart
@@ -6,7 +6,7 @@ import 'package:irllink/src/domain/usecases/settings/set_settings_usecase.dart';
 
 class SettingsService extends GetxService {
   SettingsService(
-      {required this.getSettingsUseCase, required this.setSettingsUseCase});
+      {required this.getSettingsUseCase, required this.setSettingsUseCase,});
 
   final GetSettingsUseCase getSettingsUseCase;
   final SetSettingsUseCase setSettingsUseCase;

diff --git a/lib/src/core/services/store_service.dart b/lib/src/core/services/store_service.dart
@@ -68,9 +68,9 @@ class StoreService extends GetxService {
     final ProductDetailsResponse response =
         await InAppPurchase.instance.queryProductDetails(kIds);
     if (response.notFoundIDs.isNotEmpty) {
-      talker.debug('Products not found: ${response.notFoundIDs}');
       talker
-          .debug('Products found: ${response.productDetails.map((e) => e.id)}');
+        ..debug('Products not found: ${response.notFoundIDs}')
+        ..debug('Products found: ${response.productDetails.map((e) => e.id)}');
     }
     products = response.productDetails;
   }
@@ -83,7 +83,7 @@ class StoreService extends GetxService {
       subscription.cancel();
     }, onError: (error) {
       // handle error here.
-    }) as StreamSubscription<List<PurchaseDetails>>;
+    },) as StreamSubscription<List<PurchaseDetails>>;
 
     try {
       await InAppPurchase.instance.restorePurchases();
@@ -93,7 +93,7 @@ class StoreService extends GetxService {
   }
 
   void listenToPurchaseUpdated(
-      List<PurchaseDetails> purchaseDetailsList) async {
+      List<PurchaseDetails> purchaseDetailsList,) async {
     for (var purchaseDetails in purchaseDetailsList) {
       if (purchaseDetails.status == PurchaseStatus.pending) {
         purchasePending.value = true;