This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Bunch of fixes and polish #23
Open
Otari98
wants to merge
40
commits into
Lexiebean:main
Choose a base branch
from
Otari98:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced buggy ranged weapon slot check with more consistent one Added mana regen check (for non mana classes sets to N/A) Added total avoidance line in Defenses tab Added weapon skill in Ranged and Melee tabs Every stat now have a proper tooltip (fixed old ones, added many new ones)
include set bonuses from transmogged gear
Added support for improved shadowform, mage armor Fixed ranged crit based on vmangos values Added support for tree of life and brilliance (unfortunately only counts from your own buff...for now) Update on gaining skills Bug fixes
Proper Tree of life Aura and Brilliance Aura support
added cache to avoid scanning stuff that shouldnt be scanned on each event included miss chance in total avoidance calculation
now tooltip will change if you have talents or auras that increase spell hit / crit
some stuff might be missing, or changed later
Changed Ironclad to calculate from gear armor only Added Improved Mana Shield Added Inner Fire Got rid of Brilliance Aura since its no longer a thing
added block value on block tooltip added ranged crit only items added spell damage enchants
had to disable due to a bug
+12 healing fix
increased readability
Spiritual Guidance
moved player model slightly higher (to adjust for the reduced space by added dropdowns) some code cleanup uncapped total avoidance (I believe its more informative that way)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced buggy ranged weapon slot check with more consistent one
Added mana regen check (for non mana classes sets to N/A)
Added total avoidance line in Defenses tab
Added weapon skill in Ranged and Melee tabs
Every stat now have a proper tooltip (fixed old ones, added many new ones)