Fixes wishlist icons sometimes being broken #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swaps the naming of strsplit and AtlasLoot_strplit so that strsplit is the local function and AtlasLoot_strsplit is the global function to avoid name collisions that could break determining the texture for wishlist entries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was seeing an issue in my game where GridEnhanced had also defined strsplit in the global namespace and it was breaking the icons displayed next to wishlist items.
This PR swaps the naming of strsplit and AtlasLoot_strplit so that strsplit is the local function and AtlasLoot_strsplit is the global function to avoid name collisions that could break determining the texture for wishlist entries.