Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predictions markets: beginning of smart contracts #1

Merged
merged 13 commits into from
Sep 3, 2024

Conversation

lvn-rusty-dragon
Copy link
Contributor

This isn't ready for merge or even proper review. Given the time constraints here, I'm rushing to get the contract written ASAP to unblock @lvn-alduin on frontend work. I'm hoping @lvn-hasky-dragon will be able to help out with test cases.

Also a notorious lack of tests so far.
@lvn-rusty-dragon lvn-rusty-dragon marked this pull request as ready for review September 2, 2024 16:18
@lvn-rusty-dragon
Copy link
Contributor Author

This definitely deserves more testing than what I've done, but at least there's a basic sanity check in place showing things working.

@lvn-alduin I'll follow up with you on Slack next, I think it's worth doing a deployment to Neutron testnet to unblock you on further UI work.

Copy link
Contributor

@lvn-hasky-dragon lvn-hasky-dragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from minor questions, nits etc

@lvn-hasky-dragon lvn-hasky-dragon merged commit d37acf3 into main Sep 3, 2024
1 check passed
@lvn-hasky-dragon lvn-hasky-dragon deleted the initial-contract-code branch September 3, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants