-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Predictions markets: beginning of smart contracts #1
Conversation
Also a notorious lack of tests so far.
This definitely deserves more testing than what I've done, but at least there's a basic sanity check in place showing things working. @lvn-alduin I'll follow up with you on Slack next, I think it's worth doing a deployment to Neutron testnet to unblock you on further UI work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from minor questions, nits etc
Co-authored-by: Levana Hasky Dragon <[email protected]>
This reverts commit c2ae4ec.
This isn't ready for merge or even proper review. Given the time constraints here, I'm rushing to get the contract written ASAP to unblock @lvn-alduin on frontend work. I'm hoping @lvn-hasky-dragon will be able to help out with test cases.