Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI due to NanoS support deletion in Boilerplate app #509

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Update CI due to NanoS support deletion in Boilerplate app #509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee2ddef
Update CI due to NanoS support deletion
tdejoigny-ledger Jul 26, 2024
a5d366a
PR remarks fixes
tdejoigny-ledger Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/continuous-integration-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,15 @@ jobs:
test_dir: tests
speculos_app_branch_name: ${{ github.ref }}

package_and_test_docker_for_nanos:
name: Build and test the Speculos docker for Nano S
uses: ./.github/workflows/reusable_ragger_tests_latest_speculos.yml
with:
app_repository: LedgerHQ/app-boilerplate
app_branch_name: nanos_baseline
test_dir: tests
speculos_app_branch_name: ${{ github.ref }}

deploy_docker:
name: Build and Upload the Speculos docker
runs-on: ubuntu-latest
Expand Down
24 changes: 14 additions & 10 deletions .github/workflows/reusable_ragger_tests_latest_speculos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
with:
app_repository: ${{ inputs.app_repository }}
app_branch_name: ${{ inputs.app_branch_name }}
upload_app_binaries_artifact: "compiled_app_binaries"
upload_app_binaries_artifact: compiled_app_binaries-${{ inputs.app_branch_name }}

build_docker_image:
name: Build Speculos Docker image
Expand Down Expand Up @@ -54,21 +54,25 @@ jobs:
- name: Upload artifact
uses: actions/upload-artifact@v4
with:
name: speculos_image
name: speculos_image-${{ inputs.app_branch_name }}
path: /tmp/speculos_image.tar

call_get_app_metadata:
name: Retrieve application metadata
uses: LedgerHQ/ledger-app-workflows/.github/workflows/_get_app_metadata.yml@v1
with:
app_repository: ${{ inputs.app_repository }}
app_branch_name: ${{ inputs.app_branch_name }}

ragger_tests:
name: Functional tests with Ragger
runs-on: ubuntu-latest
needs: [build_docker_image, build_application]
needs: [build_docker_image, build_application, call_get_app_metadata]
strategy:
fail-fast: false
matrix:
include:
- device: nanos
- device: nanox
- device: nanosp
- device: stax
device: ${{ fromJSON(needs.call_get_app_metadata.outputs.compatible_devices) }}

steps:
- name: Clone
uses: actions/checkout@v4
Expand All @@ -93,7 +97,7 @@ jobs:
- name: Download artifact
uses: actions/download-artifact@v4
with:
name: speculos_image
name: speculos_image-${{ inputs.app_branch_name }}
path: /tmp

- name: Load image
Expand All @@ -104,7 +108,7 @@ jobs:
- name: Download app binaries
uses: actions/download-artifact@v4
with:
name: "compiled_app_binaries"
name: compiled_app_binaries-${{ inputs.app_branch_name }}
path: ${{ github.workspace }}/app/build

- name: Run and test Speculos docker
Expand Down
Loading