Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing binutils-arm-none-eabi package #431

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

dj8yfo
Copy link
Contributor

@dj8yfo dj8yfo commented Oct 27, 2023

after pulling the image

docker pull ghcr.io/ledgerhq/speculos

when running from within the container

root@f3b12584ba7c:/speculos# ./tools/debug.sh apps/build/nanos/bin/app.elf`

an error is present in the script's output

./tools/debug.sh: line 12: arm-none-eabi-readelf: command not found

Installing the added package removes the alleged error line.

@dj8yfo dj8yfo marked this pull request as ready for review October 27, 2023 20:17
@dj8yfo
Copy link
Contributor Author

dj8yfo commented Oct 27, 2023

@xchapron-ledger please take a look sometime

@dj8yfo
Copy link
Contributor Author

dj8yfo commented Oct 30, 2023

@abonnaudet-ledger, @yhql please take a look some time

@xchapron-ledger
Copy link
Contributor

@dj8yfo Can you please update the changelog so that I can then merge and deploy a new version with your change?

@dj8yfo
Copy link
Contributor Author

dj8yfo commented Nov 7, 2023

@xchapron-ledger done

@xchapron-ledger
Copy link
Contributor

Sorry I wasn't aware they were already some undocumented changes...
Thanks for including them!

@xchapron-ledger xchapron-ledger merged commit d3efa36 into LedgerHQ:master Nov 8, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants