Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add APT mocked value #9053

Merged
merged 2 commits into from
Jan 30, 2025
Merged

fix: add APT mocked value #9053

merged 2 commits into from
Jan 30, 2025

Conversation

semeano
Copy link
Contributor

@semeano semeano commented Jan 29, 2025 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

The app was crashing when looking into an account and the history graph was not loading properly when using MOCK_COUNTERVALUES environment variable.

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@semeano semeano requested a review from a team as a code owner January 29, 2025 18:29
@vercel Vercel
Copy link

vercel bot commented Jan 29, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2025 8:19am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2025 8:19am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2025 8:19am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2025 8:19am

@semeano semeano requested a review from themooneer January 30, 2025 08:18
themooneer
themooneer approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@themooneer themooneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@semeano semeano merged commit e96114a into develop Jan 30, 2025
55 checks passed
@semeano semeano deleted the fix/aptos-mock branch January 30, 2025 09:56
This was referenced Jan 31, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themooneer themooneer themooneer approved these changes

Assignees

@semeano semeano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@semeano @themooneer