Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "🐛 Rename account and starred accounts now fixed on LLM and LLD" #9051

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

cgrellard-ledger
Copy link
Contributor

Reverts #9006

@cgrellard-ledger cgrellard-ledger requested review from a team as code owners January 29, 2025 16:59
Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2025 5:11pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2025 5:11pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2025 5:11pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2025 5:11pm

LucasWerey
LucasWerey previously approved these changes Jan 29, 2025
…tox_account_name_persist

Revert "[QAA-415][Detox][Speculos] Account name persist after restart"
@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Jan 29, 2025
@cgrellard-ledger
Copy link
Contributor Author

I've also reverted the addition of the LLM e2e test that would have been broken by this PR otherwise. I'll add those two together once the regression is fixed

@cgrellard-ledger cgrellard-ledger merged commit 294eaac into develop Jan 29, 2025
55 checks passed
@cgrellard-ledger cgrellard-ledger deleted the revert-9006-bugfix/rename-account-issue branch January 29, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants