Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update e2e loadConfig script #9045

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

mwiercinska
Copy link
Contributor

@mwiercinska mwiercinska commented Jan 29, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Folder containing test app.json files was renamed from setups to userdata but the change needed to be reflected in the e2e script that loads the config.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2025 3:38pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2025 3:38pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2025 3:38pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2025 3:38pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Jan 29, 2025
@mwiercinska mwiercinska force-pushed the chore/update-e2e-loadConfig-script branch from 7b4f2cc to dbfd94f Compare January 29, 2025 12:19
@mwiercinska mwiercinska marked this pull request as ready for review January 29, 2025 14:30
@mwiercinska mwiercinska requested review from a team as code owners January 29, 2025 14:30
@mwiercinska mwiercinska requested a review from a team January 29, 2025 14:44
.changeset/hot-roses-shave.md Outdated Show resolved Hide resolved
@mwiercinska mwiercinska merged commit fad2266 into develop Jan 29, 2025
43 checks passed
@mwiercinska mwiercinska deleted the chore/update-e2e-loadConfig-script branch January 29, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants