Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add support for mina blockchain #9016

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .changeset/witty-socks-tan.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
"@ledgerhq/types-cryptoassets": minor
"@ledgerhq/cryptoassets": minor
"@ledgerhq/types-live": minor
"@ledgerhq/crypto-icons-ui": minor
"@ledgerhq/coin-mina": minor
"ledger-live-desktop": minor
"live-mobile": minor
"@ledgerhq/live-common": minor
"@ledgerhq/coin-framework": minor
"@ledgerhq/web-tools": minor
"@ledgerhq/live-cli": minor
---

Add support for mina blockchain
1 change: 1 addition & 0 deletions apps/cli/src/live-common-setup-base.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ setSupportedCurrencies([
"mantra",
"xion",
"zenrock",
"mina",
]);

for (const k in process.env) setEnvUnsafe(k as EnvName, process.env[k]);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,4 +102,5 @@ setSupportedCurrencies([
"mantra",
"xion",
"zenrock",
"mina",
]);
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import React from "react";
import AccountSubHeader from "../../components/AccountSubHeader/index";

export default function FilecoinAccountSubHeader() {
return <AccountSubHeader family="Mina" team="Zondax"></AccountSubHeader>;
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
import React, { useCallback } from "react";
import { getAccountBridge } from "@ledgerhq/live-common/bridge/index";
import Input from "~/renderer/components/Input";
import invariant from "invariant";
import { Account } from "@ledgerhq/types-live";
import { Transaction, TransactionStatus } from "@ledgerhq/live-common/families/mina/types";
import { useTranslation } from "react-i18next";

const MemoField = ({
onChange,
account,
transaction,
status,
}: {
onChange: (a: Transaction) => void;
account: Account;
transaction: Transaction;
status: TransactionStatus;
}) => {
invariant(transaction.family === "mina", "Memo: Mina family expected");

const { t } = useTranslation();

const bridge = getAccountBridge(account);

const onMemoFieldChange = useCallback(
(value: string) => {
if (value !== "") onChange(bridge.updateTransaction(transaction, { memo: value }));
else onChange(bridge.updateTransaction(transaction, { memo: undefined }));
},
[onChange, transaction, bridge],
);

// We use transaction as an error here.
// on the ledger-live mobile
return (
<Input
warning={status.warnings.transaction}
error={status.errors.transaction}
value={transaction.memo}
placeholder={t("families.mina.memoPlaceholder")}
onChange={onMemoFieldChange}
spellCheck="false"
/>
);
};

export default MemoField;
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
import React from "react";
import { Trans } from "react-i18next";
import MemoField from "./MemoField";
import Box from "~/renderer/components/Box";
import Label from "~/renderer/components/Label";
import LabelInfoTooltip from "~/renderer/components/LabelInfoTooltip";
import { Transaction, TransactionStatus } from "@ledgerhq/live-common/families/mina/types";
import { Account } from "@ledgerhq/types-live";

const Root = (props: {
account: Account;
transaction: Transaction;
status: TransactionStatus;
onChange: (a: Transaction) => void;
trackProperties?: object;
}) => {
return (
<Box flow={1}>
<Box
horizontal
alignItems="center"
justifyContent="space-between"
style={{ width: "50%", paddingRight: 28 }}
>
<Label>
<LabelInfoTooltip text={<Trans i18nKey="families.mina.memoWarningText" />}>
<span>
<Trans i18nKey="families.mina.memo" />
</span>
</LabelInfoTooltip>
</Label>
</Box>
<Box pr={2} pl={2} mb={15} horizontal alignItems="center" justifyContent="space-between">
<Box grow={1}>
<MemoField {...props} />
</Box>
</Box>
</Box>
);
};

export default {
component: Root,
// Transaction is used here to prevent user to forward
fields: ["memo", "transaction"],
};
12 changes: 12 additions & 0 deletions apps/ledger-live-desktop/src/renderer/families/mina/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import AccountSubHeader from "./AccountSubHeader";
import sendAmountFields from "./SendAmountFields";
import operationDetails from "./operationDetails";
import { MinaFamily } from "./types";

const family: MinaFamily = {
AccountSubHeader,
operationDetails,
sendAmountFields,
};

export default family;
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
import React from "react";
import { Trans } from "react-i18next";
import {
OpDetailsTitle,
OpDetailsData,
OpDetailsSection,
} from "~/renderer/drawers/OperationDetails/styledComponents";
import Ellipsis from "~/renderer/components/Ellipsis";
import { MinaOperation } from "@ledgerhq/live-common/families/mina/types";

type OperationDetailsExtraProps = {
operation: MinaOperation;
};

const OperationDetailsExtra = ({ operation }: OperationDetailsExtraProps) => {
const { extra } = operation;
return !extra.memo ? null : (
<OpDetailsSection key={extra.memo}>
<OpDetailsTitle>
<Trans i18nKey={`operationDetails.extra.memo`} />
</OpDetailsTitle>
<OpDetailsData>
<Ellipsis>{extra.memo}</Ellipsis>
</OpDetailsData>
</OpDetailsSection>
);
};

export default {
OperationDetailsExtra,
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import {
MinaAccount,
MinaOperation,
Transaction,
TransactionStatus,
} from "@ledgerhq/live-common/families/mina/types";
import { LLDCoinFamily } from "../types";

export type MinaFamily = LLDCoinFamily<MinaAccount, Transaction, TransactionStatus, MinaOperation>;
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ const StepChooseCurrency = ({ currency, setCurrency }: StepProps) => {
const mantra = useFeature("currencyMantra");
const xion = useFeature("currencyXion");
const zenrock = useFeature("currencyZenrock");
const mina = useFeature("currencyMina");

const featureFlaggedCurrencies = useMemo(
(): Partial<Record<CryptoCurrencyId, Feature<unknown> | null>> => ({
Expand Down Expand Up @@ -146,6 +147,7 @@ const StepChooseCurrency = ({ currency, setCurrency }: StepProps) => {
mantra,
xion,
zenrock,
mina: mina,
}),
[
aptos,
Expand Down Expand Up @@ -202,6 +204,7 @@ const StepChooseCurrency = ({ currency, setCurrency }: StepProps) => {
mantra,
xion,
zenrock,
mina,
],
);

Expand Down
8 changes: 8 additions & 0 deletions apps/ledger-live-desktop/static/i18n/en/app.json
Original file line number Diff line number Diff line change
Expand Up @@ -5454,6 +5454,11 @@
"solana": {
"memo": "Tag / Memo",
"memoPlaceholder": "Optional"
},
"mina": {
"memoPlaceholder": "Optional",
"memo": "Memo",
"memoWarningText": "The value of memo can be a string shorter than or equal to 32 characters"
}
},
"errors": {
Expand Down Expand Up @@ -6474,6 +6479,9 @@
"swap": "Swap",
"deposit": "Deposit"
}
},
"InvalidMemoMina": {
"title": "Memo text cannot be longer than 32 characters"
}
},
"cryptoOrg": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import {
} from "@ledgerhq/live-common/families/solana/types";
import type { Transaction as RippleTransaction } from "@ledgerhq/live-common/families/xrp/types";
import type { Transaction as ICPTransaction } from "@ledgerhq/live-common/families/internet_computer/types";
import type { Transaction as MinaTransaction } from "@ledgerhq/live-common/families/mina/types";
import type { Transaction as StellarTransaction } from "@ledgerhq/live-common/families/stellar/types";
import type { Transaction as StacksTransaction } from "@ledgerhq/live-common/families/stacks/types";
import type { Transaction as CasperTransaction } from "@ledgerhq/live-common/families/casper/types";
Expand Down Expand Up @@ -307,6 +308,13 @@ export type SendFundsNavigatorStackParamList = {
transaction: ICPTransaction;
currentNavigation: ScreenName.SignTransactionSummary | ScreenName.SignTransactionSummary;
};
[ScreenName.MinaEditMemo]: {
accountId: string;
account: Account;
parentId?: string;
transaction: MinaTransaction;
currentNavigation: ScreenName.SignTransactionSummary | ScreenName.SignTransactionSummary;
};
[ScreenName.StacksEditMemo]: {
accountId: string;
parentId?: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import {
} from "@ledgerhq/live-common/families/solana/types";
import { Transaction as HederaTransaction } from "@ledgerhq/live-common/families/hedera/types";
import type { Transaction as ICPTransaction } from "@ledgerhq/live-common/families/internet_computer/types";
import type { Transaction as MinaTransaction } from "@ledgerhq/live-common/families/mina/types";
import type { Transaction as RippleTransaction } from "@ledgerhq/live-common/families/xrp/types";
import type { Transaction as StellarTransaction } from "@ledgerhq/live-common/families/stellar/types";
import type { Transaction as StacksTransaction } from "@ledgerhq/live-common/families/stacks/types";
Expand Down Expand Up @@ -278,6 +279,22 @@ export type SignTransactionNavigatorParamList = {
| ScreenName.SendSelectDevice
| ScreenName.SwapForm;
};
[ScreenName.MinaEditMemo]: {
accountId: string;
account: Account;
parentId?: string;
transaction: MinaTransaction;
currentNavigation:
| ScreenName.SignTransactionSummary
| ScreenName.SignTransactionSummary
| ScreenName.SendSummary
| ScreenName.SwapForm;
nextNavigation:
| ScreenName.SignTransactionSelectDevice
| ScreenName.SignTransactionSelectDevice
| ScreenName.SendSelectDevice
| ScreenName.SwapForm;
};
[ScreenName.CasperEditTransferId]: {
accountId: string;
account: Account;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ import {
import { Transaction as HederaTransaction } from "@ledgerhq/live-common/families/hedera/types";
import type { Transaction as RippleTransaction } from "@ledgerhq/live-common/families/xrp/types";
import type { Transaction as ICPTransaction } from "@ledgerhq/live-common/families/internet_computer/types";
import type { Transaction as MinaTransaction } from "@ledgerhq/live-common/families/mina/types";
import type { Transaction as StellarTransaction } from "@ledgerhq/live-common/families/stellar/types";
import type { Transaction as StacksTransaction } from "@ledgerhq/live-common/families/stacks/types";
import type { Transaction as CasperTransaction } from "@ledgerhq/live-common/families/casper/types";
Expand Down Expand Up @@ -269,6 +270,13 @@ export type SwapNavigatorParamList = {
transaction: ICPTransaction;
currentNavigation: ScreenName.SignTransactionSummary | ScreenName.SignTransactionSummary;
};
[ScreenName.MinaEditMemo]: {
accountId: string;
account: Account;
parentId?: string;
transaction: MinaTransaction;
currentNavigation: ScreenName.SignTransactionSummary | ScreenName.SignTransactionSummary;
};

[ScreenName.StacksEditMemo]: {
accountId: string;
Expand Down
2 changes: 2 additions & 0 deletions apps/ledger-live-mobile/src/const/navigation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,8 @@ export enum ScreenName {

// ton
TonEditComment = "TonEditComment",
// mina
MinaEditMemo = "MinaEditMemo",

// Algorand
AlgorandEditMemo = "AlgorandEditMemo",
Expand Down
1 change: 1 addition & 0 deletions apps/ledger-live-mobile/src/families/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ export * from "./elrond";
export * from "./evm";
export * from "./hedera";
export * from "./internet_computer";
export * from "./mina";
export * from "./near";
export * from "./polkadot";
export * from "./xrp";
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import React from "react";
import AccountSubHeader from "~/components/AccountSubHeader";

function InternetComputerAccountSubHeader() {
return <AccountSubHeader family="Mina" team="Zondax" />;
}

export default InternetComputerAccountSubHeader;
Loading
Loading