Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LIVE-16529] Fix Add Custom Manifest Screen #8996

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[LIVE-16529] Fix Add Custom Manifest Screen #8996

wants to merge 2 commits into from
+73 −28

Conversation

chrisduma-ledger
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Arranged the Add Custom Manifest screen's UI

❓ Context

Ticket

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@chrisduma-ledger chrisduma-ledger requested a review from a team as a code owner January 24, 2025 14:13
@vercel Vercel
Copy link

vercel bot commented Jan 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2025 2:15pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2025 2:15pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2025 2:15pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2025 2:15pm

@live-github-bot live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels Jan 24, 2025
@chrisduma-ledger chrisduma-ledger changed the title feat: fix llm screen [LIVE-16529] Fix Add Custom Manifest Screen Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chrisduma-ledger chrisduma-ledger

Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chrisduma-ledger