Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add analytics to add account v2 flow #8990

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat: add analytics to add account v2 flow #8990

wants to merge 2 commits into from
+644 −126

Conversation

themooneer
Copy link
Contributor

@themooneer themooneer commented Jan 23, 2025 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Setup analytics metadata for add account v2 process

See analytics keys here starting from User accesses asset selection screen

❓ Context

  • JIRA or GitHub link:

https://ledgerhq.atlassian.net/browse/LIVE-15722

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Jan 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2025 3:32pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2025 3:32pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2025 3:32pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2025 3:32pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Jan 23, 2025
@themooneer themooneer force-pushed the analytics/addAccountv2 branch 7 times, most recently from ff052b9 to b37bbf9 Compare January 23, 2025 16:39
@themooneer themooneer marked this pull request as ready for review January 23, 2025 16:40
@themooneer themooneer requested review from a team as code owners January 23, 2025 16:40
valpinkman
valpinkman previously approved these changes Jan 23, 2025
View reviewed changes
@themooneer themooneer force-pushed the analytics/addAccountv2 branch from b37bbf9 to caa3dcc Compare January 24, 2025 09:11
@themooneer themooneer requested a review from valpinkman January 24, 2025 09:42
valpinkman
valpinkman previously approved these changes Jan 24, 2025
View reviewed changes
@themooneer themooneer force-pushed the analytics/addAccountv2 branch from caa3dcc to 0220196 Compare January 24, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgrellard-ledger cgrellard-ledger cgrellard-ledger approved these changes

@valpinkman valpinkman Awaiting requested review from valpinkman

At least 1 approving review is required to merge this pull request.

Assignees

@themooneer themooneer

Labels
mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@themooneer @valpinkman @cgrellard-ledger