Code

Merge develop into master#40

Code

Merged

yogh333 merged 132 commits intomainLedgerHQ/app-starknet:mainfrom developLedgerHQ/app-starknet:developCopy head branch name to clipboardDec 6, 2024

+9,467-2,654

Commits

Commits on May 23, 2024

• Update CI: Ragger tests

  yogh333

  committed
  52508b8

  Copy full SHA for 52508b8

• CI: update manifest file

  yogh333

  committed
  be831d8

  Copy full SHA for be831d8

• Signing: hash shall be always confirmed by user before signing

  yogh333

  committed
  c5fd569

  Copy full SHA for c5fd569

Commits on May 24, 2024

• Stax/Flex porting

  yogh333

  committed
  8b6d14f

  Copy full SHA for 8b6d14f

Commits on May 27, 2024

• Use NbglAddressReview in place of NbglAddressConfirm (API update)

  yogh333

  committed
  40b5f84

  Copy full SHA for 40b5f84

Commits on May 28, 2024

• Every string shall be null terminated

  yogh333

  committed
  6044f97

  Copy full SHA for 6044f97

• Update Ragger tests for Stax/Flex

  yogh333

  committed
  1effd19

  Copy full SHA for 1effd19

• Keep using Rust string (non null terminated) as it is fully managed by SDK

  yogh333

  committed
  325b7a7

  Copy full SHA for 325b7a7

Commits on May 30, 2024

• Ragger tests OK with SP, X, Stax

  yogh333

  committed
  926b527

  Copy full SHA for 926b527

• Add golden snapshots for Flex + Ragger tests Flex OK

  yogh333

  committed
  58fc573

  Copy full SHA for 58fc573

Commits on May 31, 2024

• Bump SDK version

  yogh333

  committed
  e2178f8

  Copy full SHA for e2178f8

Commits on Jun 4, 2024

• Bump SDK and app versions

  yogh333

  committed
  bdbc9c6

  Copy full SHA for bdbc9c6

• Add helper

  yogh333

  committed
  66d6723

  Copy full SHA for 66d6723

Commits on Jun 14, 2024

• Update SDK and set panic handler

  yogh333

  committed
  96e2cee

  Copy full SHA for 96e2cee

• Bump version + update tests

  yogh333

  committed
  cf3a17b

  Copy full SHA for cf3a17b

• Update docs

  yogh333

  committed
  51dba7b

  Copy full SHA for 51dba7b

• Flip Starknet logo for NanoS

  yogh333

  committed
  c4ecb2c

  Copy full SHA for c4ecb2c

• Update snapshots

  yogh333

  committed
  a0f3355

  Copy full SHA for a0f3355

• Merge pull request #23 from LedgerHQ/y333/update_sdk

  Show description for a643f4d
  yogh333

  authored
  a643f4d

  Copy full SHA for a643f4d

• Update README.md

  yogh333

  authored
  588c669

  Copy full SHA for 588c669

Commits on Jul 2, 2024

• Bump SDK version

  yogh333

  committed
  db93a5e

  Copy full SHA for db93a5e

• Update snapshots

  yogh333

  committed
  ba0c319

  Copy full SHA for ba0c319

• Bump version and remove Nano S support

  yogh333

  committed
  50ddad4

  Copy full SHA for 50ddad4

• Update version snapshots

  yogh333

  committed
  d2c6be5

  Copy full SHA for d2c6be5

• Merge pull request #25 from LedgerHQ/y333/use_allocator

  Show description for eb0a93a
  yogh333

  authored
  eb0a93a

  Copy full SHA for eb0a93a

Commits on Jul 5, 2024

• Felt arithmetic operations (+, -, x, /) OK

  yogh333

  committed
  8b6867d

  Copy full SHA for 8b6867d

Commits on Jul 8, 2024

• Poseidon first implementation (ported from Lambdaclass work)

  yogh333

  committed
  fbe7f39

  Copy full SHA for fbe7f39

• Optimised Poseidon hash

  yogh333

  committed
  c658481

  Copy full SHA for c658481

• Benchmarking Poseidon implementation

  yogh333

  committed
  89e69e5

  Copy full SHA for 89e69e5

Commits on Jul 9, 2024

• Poseidon: integrate mix function

  yogh333

  committed
  7fa9bcf

  Copy full SHA for 7fa9bcf

• Poseidon hasher implementation

  yogh333

  committed
  09efb5e

  Copy full SHA for 09efb5e

Commits on Jul 10, 2024

• Hash Tx v3

  yogh333

  committed
  b08f07d

  Copy full SHA for b08f07d

Commits on Jul 12, 2024

• Fix Poseidon hash of calldata

  yogh333

  committed
  4d04289

  Copy full SHA for 4d04289

Commits on Jul 15, 2024

• Tx hash OK on speculos but KO on device

  yogh333

  committed
  cc54fb3

  Copy full SHA for cc54fb3

Commits on Jul 16, 2024

• Tx hash OK but unoptimized mix function

  yogh333

  committed
  39cbe4d

  Copy full SHA for 39cbe4d

• Cleanup

  yogh333

  committed
  b77db8b

  Copy full SHA for b77db8b

• Tx hash OK on both speculos and device (Poseidon optimized)

  yogh333

  committed
  bc4d15c

  Copy full SHA for bc4d15c

• Try to optimise partial_round loop

  yogh333

  committed
  7ab2244

  Copy full SHA for 7ab2244

• Increase Poseidon perf with partial_round_loop

  yogh333

  committed
  a59a0cb

  Copy full SHA for a59a0cb

Commits on Jul 17, 2024

• Add shifting hash function

  yogh333

  committed
  99ef717

  Copy full SHA for 99ef717

Commits on Jul 18, 2024

• Add UI screens

  yogh333

  committed
  c987726

  Copy full SHA for c987726

Commits on Jul 22, 2024

• Implement complete Tx signature flow for Stax/Flex

  yogh333

  committed
  63e11a6

  Copy full SHA for 63e11a6

• Implement complete Tx signature flow for Nanos

  yogh333

  committed
  8806d9d

  Copy full SHA for 8806d9d

Commits on Jul 23, 2024

• Add apdu-generator and switch to workspace

  yogh333

  committed
  e1b49a1

  Copy full SHA for e1b49a1

• Generate apdu files

  yogh333

  committed
  2a9c653

  Copy full SHA for 2a9c653

• Add check-signature app

  yogh333

  committed
  c483a7c

  Copy full SHA for c483a7c

Commits on Jul 24, 2024

• [check-signature] Add possibility to pass args

  yogh333

  committed
  73ff4d1

  Copy full SHA for 73ff4d1

Commits on Jul 26, 2024

• [starknet] Return Tx hash along with Tx signature

  yogh333

  committed
  a713602

  Copy full SHA for a713602

• [tests, tools] Update Ragger tests and apdu_generator

  yogh333

  committed
  be045fb

  Copy full SHA for be045fb

• [apdu-generator] Add get_pubkey apdus

  yogh333

  committed
  2e1b070

  Copy full SHA for 2e1b070

Commits on Jul 29, 2024

• Bump SDK version

  yogh333

  committed
  80f25e1

  Copy full SHA for 80f25e1

• [starknet] Update ragger tests

  yogh333

  committed
  2996df4

  Copy full SHA for 2996df4

• [starknet] Signing hash or Poseidon computation enabled as features only + use GenericReview to display Public Key

  yogh333

  committed
  abdedf4

  Copy full SHA for abdedf4

• [starknet] Update Ragger tests

  yogh333

  committed
  d89b2c2

  Copy full SHA for d89b2c2

Commits on Jul 30, 2024

• [starknet] Cleanup Ragger tests

  yogh333

  committed
  51c498d

  Copy full SHA for 51c498d

• Delete unused test folder

  yogh333

  committed
  578e84e

  Copy full SHA for 578e84e

• [starknet] Bump version

  yogh333

  committed
  91454ce

  Copy full SHA for 91454ce

• Update documentation

  yogh333

  committed
  45410a5

  Copy full SHA for 45410a5

• Update docs

  yogh333

  committed
  cc4724f

  Copy full SHA for cc4724f

• Update snapshots after version bump

  yogh333

  committed
  88b1572

  Copy full SHA for 88b1572

Commits on Aug 1, 2024

• [starknet] Bump SDK version and manage status in application

  yogh333

  committed
  1424647

  Copy full SHA for 1424647

• [starknet] Display max fees in fri (STRK 10e-18) units

  yogh333

  committed
  d85bf94

  Copy full SHA for d85bf94

• [check-signature] use git path for legder-lib

  yogh333

  committed
  8c7dae2

  Copy full SHA for 8c7dae2

• [apdu-generator] Run cargo fmt

  yogh333

  committed
  21d455e

  Copy full SHA for 21d455e

Commits on Aug 2, 2024

• Fix CI workflow

  yogh333

  committed
  8a16c40

  Copy full SHA for 8a16c40

• CI test

  yogh333

  committed
  181a13c

  Copy full SHA for 181a13c

• CI: fix guidelines_enforcer

  yogh333

  committed
  42ab710

  Copy full SHA for 42ab710

• [starknet] Fix clippy issues

  yogh333

  committed
  305a1bc

  Copy full SHA for 305a1bc

• [starknet] fix clippy issue (Nano build)

  yogh333

  committed
  a3fd059

  Copy full SHA for a3fd059

Commits on Aug 21, 2024

• [starknet] updates after Donjon review

  yogh333

  committed
  911c289

  Copy full SHA for 911c289

Commits on Aug 28, 2024

• Update APDU protocol: for each call, an end-of-calldata shall be received

  yogh333

  committed
  9ff80d7

  Copy full SHA for 9ff80d7

Commits on Sep 4, 2024

• Bump SDK version

  yogh333

  committed
  3307d99

  Copy full SHA for 3307d99

• Merge pull request #28 from LedgerHQ/y333/poseidon_support

  Show description for 1788c02
  yogh333

  authored
  1788c02

  Copy full SHA for 1788c02

Commits on Sep 11, 2024

• Support Tx v1

  yogh333

  committed
  ac22e5b

  Copy full SHA for ac22e5b

Commits on Sep 12, 2024

• Re-enable signHash() function

  yogh333

  committed
  2544052

  Copy full SHA for 2544052

• Update Ragger tests: read apdus from data file

  yogh333

  committed
  0507d0e

  Copy full SHA for 0507d0e

• Update Ragger: tx V1 clear and blind signing

  yogh333

  committed
  81ac479

  Copy full SHA for 81ac479

• Update Ragger: sign hash

  yogh333

  committed
  8eb6e5b

  Copy full SHA for 8eb6e5b

• Test sign Hash OK

  yogh333

  committed
  e45e02a

  Copy full SHA for e45e02a

Commits on Sep 13, 2024

• Fix Pedersen hash for v1 Tx

  yogh333

  committed
  9043b19

  Copy full SHA for 9043b19

Commits on Sep 16, 2024

• Fix shifting hash function

  yogh333

  committed
  ec040cf

  Copy full SHA for ec040cf

• Update tools

  yogh333

  committed
  bf8f70f

  Copy full SHA for bf8f70f

• Ragger tests OK

  yogh333

  committed
  faa4c90

  Copy full SHA for faa4c90

• Update CI: build check-signature binary

  yogh333

  committed
  da98a27

  Copy full SHA for da98a27

• Update CI: fix typo

  yogh333

  committed
  f11fe4e

  Copy full SHA for f11fe4e

• Update CI: fix typo again

  yogh333

  committed
  6666e36

  Copy full SHA for 6666e36

• Run clippy

  yogh333

  committed
  2ed4fb8

  Copy full SHA for 2ed4fb8

• Make check-binary executable if needed

  yogh333

  committed
  4571585

  Copy full SHA for 4571585

Commits on Sep 17, 2024

• Make difference in between signing a hash and signing a Tx hash

  yogh333

  committed
  e9d6082

  Copy full SHA for e9d6082

Commits on Sep 18, 2024

• ÃÃUpdate Rust SDK and use proper TransactionType

  yogh333

  committed
  0eb5b06

  Copy full SHA for 0eb5b06

• Use last Rust SDK

  yogh333

  committed
  15f4353

  Copy full SHA for 15f4353

Commits on Sep 19, 2024

• Update HomeAndSettings

  yogh333

  committed
  9c9096f

  Copy full SHA for 9c9096f

Commits on Sep 20, 2024

• Use new NBGL HomeAndSettings

  yogh333

  committed
  9e76145

  Copy full SHA for 9e76145

• Use display()

  yogh333

  committed
  ebd5c30

  Copy full SHA for ebd5c30

Commits on Sep 23, 2024

• Use last Rust SDK

  yogh333

  committed
  4248780

  Copy full SHA for 4248780

• Fix clippy issue

  yogh333

  committed
  d4a72ea

  Copy full SHA for d4a72ea

• Merge pull request #33 from LedgerHQ/y333/starknet_nbgl2

  Show description for cdd2699
  yogh333

  authored
  cdd2699

  Copy full SHA for cdd2699

Commits on Sep 24, 2024

• Update after Donjon review

  yogh333

  committed
  c3bd1cc

  Copy full SHA for c3bd1cc

Commits on Sep 26, 2024

• Update doc (APDU protocol)

  yogh333

  committed
  bd982f5

  Copy full SHA for bd982f5

• Use last Rust SDK and delete traces

  yogh333

  committed
  eeba855

  Copy full SHA for eeba855

• Merge pull request #32 from LedgerHQ/y333/milestone1_redux

  Show description for 0e4dce5
  yogh333

  authored
  0e4dce5

  Copy full SHA for 0e4dce5

Commits on Oct 1, 2024

• Update Ragger tests and snapshots

  yogh333

  committed
  c21b983

  Copy full SHA for c21b983

• Update Rust SDK version

  yogh333

  committed
  0a3120e

  Copy full SHA for 0a3120e

• Update snapshots for Stax/Flex

  yogh333

  committed
  2d2cb0d

  Copy full SHA for 2d2cb0d

• Merge pull request #34 from LedgerHQ/y333/update_ragger_tests

  Show description for bacad90
  yogh333

  authored
  bacad90

  Copy full SHA for bacad90

Commits on Oct 7, 2024

• Use custom NbglReviewDisplay

  yogh333

  committed
  5387c6f

  Copy full SHA for 5387c6f

• Use buffer to store data to be sent back through comm object

  yogh333

  committed
  979099e

  Copy full SHA for 979099e

• Remove comments

  yogh333

  committed
  d87f01b

  Copy full SHA for d87f01b

Commits on Oct 8, 2024

• Update Rust SDK

  yogh333

  committed
  a9961f5

  Copy full SHA for a9961f5

Commits on Oct 9, 2024

• Remove traces as it makes NanoX crashes

  yogh333

  committed
  de6f214

  Copy full SHA for de6f214

• Merge pull request #35 from LedgerHQ/y333/stax_workaround

  Show description for d64cf9f
  yogh333

  authored
  d64cf9f

  Copy full SHA for d64cf9f

Commits on Oct 16, 2024

• Display max fee in toke,n units + add Ox prefix when displaying address

  yogh333

  committed
  da366a8

  Copy full SHA for da366a8

Commits on Oct 22, 2024

• Refactor complete: Nano SP + Flex tests OK

  yogh333

  committed
  9f91a2c

  Copy full SHA for 9f91a2c

Commits on Oct 23, 2024

• [apdu-generator] Generate Deploy Account v1 and v3

  yogh333

  committed
  0bbac40

  Copy full SHA for 0bbac40

• Implement deploy_account clear-signing support + Ragger tests Ok (w/o deploy_account)

  yogh333

  committed
  e709812

  Copy full SHA for e709812

Commits on Oct 24, 2024

• [apdu-generator] fix P1 in deploy_account APDUs

  yogh333

  committed
  0858b7b

  Copy full SHA for 0858b7b

• Ragger tests OK

  yogh333

  committed
  1aca211

  Copy full SHA for 1aca211

• Blind signing setting management (Stax & Flex)

  yogh333

  committed
  a18fd05

  Copy full SHA for a18fd05

Commits on Oct 25, 2024

• Add missing contract_address_salt in sample

  yogh333

  committed
  a3d45c0

  Copy full SHA for a3d45c0

• Bump version, update test app mainmenu, update Rust SDK

  yogh333

  committed
  2dbdd50

  Copy full SHA for 2dbdd50

• Merge pull request #38 from LedgerHQ/y333_241016/update_after_product_review

  Show description for 65325f9
  yogh333

  authored
  65325f9

  Copy full SHA for 65325f9

Commits on Oct 29, 2024

• Add blind signing settings on Nano S+/X

  yogh333

  committed
  3e4f8dc

  Copy full SHA for 3e4f8dc

• Fix wording when deploying account

  yogh333

  committed
  6807468

  Copy full SHA for 6807468

• Decrease friction for Nano S+/X

  yogh333

  committed
  93d3c22

  Copy full SHA for 93d3c22

• When blind signing, display Computing Hash message

  yogh333

  committed
  5179c76

  Copy full SHA for 5179c76

• Fix wording and amount display

  yogh333

  committed
  a84c9cf

  Copy full SHA for a84c9cf

• Update snapshots + fix clippy issues

  yogh333

  committed
  bb24a6c

  Copy full SHA for bb24a6c

• Return Tx signature result while displaying final status on device

  yogh333

  committed
  e5cbde5

  Copy full SHA for e5cbde5

• Use Option<> if returning non-empty data

  yogh333

  committed
  c5f6123

  Copy full SHA for c5f6123

• Fix clippy issue

  yogh333

  committed
  a65ac6f

  Copy full SHA for a65ac6f

Commits on Oct 30, 2024

• Revert displaying status while sending back data

  yogh333

  committed
  6e29c6d

  Copy full SHA for 6e29c6d

• Merge pull request #39 from LedgerHQ/y333_241029/product_feedback

  Show description for 9a26ac4
  yogh333

  authored
  9a26ac4

  Copy full SHA for 9a26ac4