Fix bls aggregation for multiple quorums

services/bls_aggregation/blsagg.go

@@ -444,12 +444,22 @@ func (a *BlsAggregatorService) singleTaskAggregatorGoroutineFunc(
 			// after verifying signature we aggregate its sig and pubkey, and update the signed stake amount
 			if !ok {
 				// first operator to sign on this digest
+				signersApkG2 := bls.NewZeroG2Point()
+				signersAggSigG1 := bls.NewZeroSignature()
+				// for each quorum the operator has stake in, the signature is aggregated
+				// see
+				// https://github.com/Layr-Labs/eigenlayer-middleware/blob/7d49b5181b09198ed275783453aa082bb3766990/src/BLSSignatureChecker.sol#L161-L168
+				for range operatorsAvsStateDict[signedTaskResponseDigest.OperatorId].StakePerQuorum {
+					signersApkG2 = signersApkG2.Add(
+						operatorsAvsStateDict[signedTaskResponseDigest.OperatorId].OperatorInfo.Pubkeys.G2Pubkey,
+					)
+					signersAggSigG1 = signersAggSigG1.Add(signedTaskResponseDigest.BlsSignature)
+				}
 				digestAggregatedOperators = aggregatedOperators{
 					// we've already verified that the operator is part of the task's quorum, so we don't need checks
 					// here
-					signersApkG2: bls.NewZeroG2Point().
-						Add(operatorsAvsStateDict[signedTaskResponseDigest.OperatorId].OperatorInfo.Pubkeys.G2Pubkey),
-					signersAggSigG1:       signedTaskResponseDigest.BlsSignature,
+					signersApkG2:          signersApkG2,
+					signersAggSigG1:       signersAggSigG1,
 					signersOperatorIdsSet: map[types.OperatorId]bool{signedTaskResponseDigest.OperatorId: true},
 					signersTotalStakePerQuorum: cloneStakePerQuorumMap(
 						operatorsAvsStateDict[signedTaskResponseDigest.OperatorId].StakePerQuorum,
@@ -460,10 +470,11 @@ func (a *BlsAggregatorService) singleTaskAggregatorGoroutineFunc(
 					"taskIndex", taskIndex,
 					"taskResponseDigest", taskResponseDigest)
 
-				digestAggregatedOperators.signersAggSigG1.Add(signedTaskResponseDigest.BlsSignature)
-				digestAggregatedOperators.signersApkG2.Add(operatorsAvsStateDict[signedTaskResponseDigest.OperatorId].OperatorInfo.Pubkeys.G2Pubkey)
 				digestAggregatedOperators.signersOperatorIdsSet[signedTaskResponseDigest.OperatorId] = true
+				// for each quorum the operator has stake in, the signature is aggregated
 				for quorumNum, stake := range operatorsAvsStateDict[signedTaskResponseDigest.OperatorId].StakePerQuorum {
+					digestAggregatedOperators.signersAggSigG1.Add(signedTaskResponseDigest.BlsSignature)
+					digestAggregatedOperators.signersApkG2.Add(operatorsAvsStateDict[signedTaskResponseDigest.OperatorId].OperatorInfo.Pubkeys.G2Pubkey)
 					if _, ok := digestAggregatedOperators.signersTotalStakePerQuorum[quorumNum]; !ok {
 						// if we haven't seen this quorum before, initialize its signed stake to 0
 						// possible if previous operators who sent us signatures were not part of this quorum