registry coordinator refactor #350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8sunyuan
reviewed
Jan 13, 2025
| */ | ||
| function becomeOperatorSetAVS() external onlyOwner { | ||
| // Enable operator sets mode | ||
| isOperatorSetAVS = true; |
There was a problem hiding this comment.
Mentioned this in the original PR but imo this should be the default setting and have this set to true in the initialize function
8sunyuan
reviewed
Jan 13, 2025
| * @param data Custom data containing The G1 & G2 public keys of the operator, and a signature proving their ownership | ||
| * @dev This function is an AllocationManager-based registration where the msg.sender is the AllocationManager | ||
| * @dev `data` is ignored if the caller has previously registered a public key | ||
| */ | ||
| function registerOperator( |
There was a problem hiding this comment.
Note: for this function, since its being called by the ALM !_validateM2Quorums(quorumNumbers); is not needed as its already validated by the ALM
There was a problem hiding this comment.
So for registration, M2 quorums can only be registered for through the legacy interface and OperatorSet quorums can only be registered through the new ALM callback. Similarly for deregistering, there are 2 separate interfaces for the respective quorum types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_registerOperatorfunction, mimicking how there is a single_deregisterOperatorinternal functionallocationManagerbecomeOperatorSetAVSis called