Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Solana from CI #1233

Closed
wants to merge 1 commit into from
Closed

Remove Solana from CI #1233

wants to merge 1 commit into from

Conversation

DanL0
Copy link
Contributor

@DanL0 DanL0 commented Feb 4, 2025 •
edited
Loading

Removes Solana from CI because currently build is broken and works only due to caching.

Tests were disabled before anyway:

# FIXME The Solana tests need to be ported to either use a stable deployment
# or a local node. Until then, we disable the tests
# LZ_DEVTOOLS_ENABLE_SOLANA_TESTS: 1

@DanL0 DanL0 marked this pull request as ready for review February 4, 2025 09:15
@DanL0 DanL0 changed the title remove solana from CI Remove solana from CI Feb 4, 2025
@DanL0 DanL0 changed the title Remove solana from CI Remove Solana from CI Feb 4, 2025
@DanL0 DanL0 requested review from a team February 4, 2025 09:16
shankars99
shankars99 reviewed Feb 4, 2025
View reviewed changes
Dockerfile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im afraid that changing the Dockerfile would affect devcontainer (.devcontainer/devcontainer.local.json) since it depends on Dockerfile.
This may result in us not having solana in future devtools named volume

AlexanderLiteplo
AlexanderLiteplo approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@AlexanderLiteplo AlexanderLiteplo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Lets get this unblocked.

@DanL0
Copy link
Contributor Author

DanL0 commented Feb 5, 2025

closing because of devcontainer use

@DanL0 DanL0 closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shankars99 shankars99 shankars99 left review comments

@AlexanderLiteplo AlexanderLiteplo AlexanderLiteplo approved these changes

Assignees
No one assigned
Labels
do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DanL0 @shankars99 @AlexanderLiteplo @ryandgoulding