chore: improve the default NativeOFTAdapter.quoteOFT() method #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method is meant to be overriden. This function should not fail, and keeping the default OFTCore.quoteOFT(...) implementation was leading to failed calls as Native tokens aren't ERC-20. Signed-off-by: Ryan Goulding <[email protected]>
ryandgoulding
force-pushed
the
chore/improve_quoteOFT
branch
from
e13d57f to
74c41a6
Compare
|
This PR is meant to replace #1227 |
DanL0
previously approved these changes
Feb 4, 2025
Signed-off-by: Ryan Goulding <[email protected]>
DanL0
approved these changes
Feb 4, 2025
ItsAdel
approved these changes
Feb 4, 2025
TRileySchwarz
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is meant to be overriden. This function should not fail, and keeping the default OFTCore.quoteOFT(...) implementation was leading to failed calls as Native tokens aren't ERC-20.