Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.1.2 update, upgrades mbedtls #27

Merged
merged 4 commits into from
Nov 11, 2024
Merged

V1.1.2 update, upgrades mbedtls #27

merged 4 commits into from
Nov 11, 2024

Conversation

WinterSolstice8
Copy link
Member

@WinterSolstice8 WinterSolstice8 commented Nov 11, 2024

Small update here

@WinterSolstice8
Copy link
Member Author

This is what it looks like now with the mbedtls prints. I picked a different color to delineate that this is a dependency version:

image

@WinterSolstice8
Copy link
Member Author

WinterSolstice8 commented Nov 11, 2024

I just had a thought on the commit to ignore the CA root certificate warning. The input is the flags, and if we ever see a warning that ISNT the root certificate warning, it may also print that instead. However, if we set the flags as such:

flags &= ~MBEDTLS_X509_BADCERT_NOT_TRUSTED it should also never print that warning. This could lead to less confusion if there is an error. Thoughts?

@WinterSolstice8
Copy link
Member Author

I updated the code with that, I think it makes sense if we ignore that warning normally anyway.

@WinterSolstice8
Copy link
Member Author

Godbolt link showing it only removes the bits we want:
https://godbolt.org/z/3nKoaGnK4

@zach2good
Copy link
Collaborator

While you're here, can you absorb this PR please (if still relevant): #25

@WinterSolstice8
Copy link
Member Author

No idea if that's relevant since we don't print a warning by default anymore

@WinterSolstice8
Copy link
Member Author

it always appends a newline at the end, but I figured I should be able to print the timestamp (code hacked to allow old warning to show)
image

Copy link
Collaborator

@zach2good zach2good left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@zach2good zach2good merged commit d02e7a2 into main Nov 11, 2024
1 check passed
@zach2good zach2good deleted the 1.1.2 branch November 11, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants