LibWeb/SVG: Skip unnwanted transformations on clip-path #3178
+44
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gingeh
force-pushed
the
clip-path-transform
branch
from
2a2b0a1 to
388289e
Compare
Gingeh
force-pushed
the
clip-path-transform
branch
from
388289e to
7a6fcb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1624.
Also fixes the logo on https://sdr-podcast.com/ and the banners on https://neal.fun/.
I'm not 100% certain this is the best fix, but I made a test file (included in this PR) which covers all places in the tree that a clip path and target can be transformed.
Transformed clip-paths are still incorrect when using
clipPathUnits="objectBoundingBox", I suspect it's because the outer transformations are applied after it is scaled (I will open an issue if this is merged).