LibWeb: Emit comment token for unterminated bogus comments on EOF #3158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcl3
commented
Jan 6, 2025
Comment on lines
+490
to
+491
| m_current_token.set_comment(consume_current_builder()); | ||
| EMIT_CURRENT_TOKEN_FOLLOWED_BY_EOF; |
There was a problem hiding this comment.
The spec text here says:
Emit the comment. Emit an end-of-file token.
The spec text for the comment start dash state, says:
This is an eof-in-comment parse error. Emit the current comment token. Emit an end-of-file token.
This PR makes these 2 states behave the same way. Should there be a difference in behavior here? I'm not familiar enough with the spec language to know for sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the 1 remaining failing subtest in http://wpt.live/html/syntax/parsing/html5lib_comments01.html