Potentially helpful functions? #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rqthomas
reviewed
Apr 10, 2024
| filter(datetime >= forecast_date) %>% | ||
| pivot_wider(names_from = variable, values_from = prediction) | ||
|
|
||
| write.csv(weather_pred_export, |
There was a problem hiding this comment.
Would it be better to return the data frame and let the user write the file format of their choice? or is there a specific reason for serialized to csv in the function?
| longitude = long, | ||
| forecast_days = forecast_days, # days into the future | ||
| past_days = 92, # past days that can be used for model fitting | ||
| model = "gfs_seamless", # this is the NOAA gefs ensemble model |
There was a problem hiding this comment.
I would add model to the arguement so they can download a different open_meteo models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per CCC request: two functions that load met data and format to match vera P1D targets. Might need to be modified for other applications