refactor region handling #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoanneBogart
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Very nice. The old arrangement of some of this stuff was pretty unwieldy. Short docstrings for at least Region.compute_mask and Region.refcat_region would be helpful.
My only reservation is about the name refcat_region since the notion of a refcat is not really within the scope of shapes. I'd prefer something like sphgeom_region but can live with it as is.
|
Thanks! I'll add those docstrings and will rename the method to something more generic like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes will make it easier for third parties to implement their own object classes.