populate copier template #38
Conversation
| @@ -20,7 +20,8 @@ def test_flexzboost(): | |||
| 'reg:squarederror'}, | |||
| 'hdf5_groupname': 'photometry', | |||
| 'model': 'model.tmp'} | |||
| estim_config_dict = {'hdf5_groupname': 'photometry', | |||
| estim_config_dict = {'zmin': 0.0, 'zmax': 3.0, 'nzbins': 301, | |||
There was a problem hiding this comment.
So this is fine to get the tests to pass, but the slightly awkward thing is, when using the basis function parameterization with FZBoost, the zmin and zmax are used in defining the basis functions themselves, and as such, they are stored internally in the FZBoost model params in the inform stage, and thus they are not default parameters in the Estimator stage.
The current mixin class looks for zmin and zmax to calculate the point estimates, but for FlexZBoost in particular, zmin and zmax are required only for the calculation of the point estimates. They are also now essentially required parameters, as we get an error if they are not present. So, maybe we should add zmin and zmax back in to the config_options.update for FlexZBoostEstimator with a msg saying that they are used only for the point estimate calculation?
There was a problem hiding this comment.
It's subtly different than most of the other estimators where zmin and zmax are required parameters to construct the grid in all cases, that's why I'm mentioning it here, if that makes sense.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
===========================================
+ Coverage 94.48% 100.00% +5.51%
===========================================
Files 1 1
Lines 127 127
Branches 17 0 -17
===========================================
+ Hits 120 127 +7
+ Partials 7 0 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
No description provided.