Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tqz/utils refactor #44

Merged
merged 5 commits into from
May 8, 2024
Merged

Tqz/utils refactor #44

merged 5 commits into from
May 8, 2024

Conversation

ztq1996
Copy link
Contributor

@ztq1996 ztq1996 commented May 8, 2024

Problem & Solution Description (including issue #)

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

@ztq1996 ztq1996 requested a review from hangqianjun May 8, 2024 15:22
@ztq1996
Copy link
Contributor Author

ztq1996 commented May 8, 2024

@sschmidt23 Seems like one unit test failed genuinely here, has that always been the case?

@sschmidt23
Copy link
Collaborator

Hmm, I have seen this test fail every once in a while, our test set galaxies are all very low redshift with fairly flat PDFs, so the mode can sometimes shift a bit when even small changes are introduced (maybe by things like updates to numpy/scipy). I think several of the other estimators have commented out the np.isclose assert statement because of similar issues. I'll look into it shortly.

@sschmidt23
Copy link
Collaborator

I updated to new values and added an atol=0.03. If there are more failures in the future we can think about just dropping the assert statement that checks expected values.

@ztq1996
Copy link
Contributor Author

ztq1996 commented May 8, 2024

Thank you Sam!

@ztq1996 ztq1996 merged commit 7ee9e42 into main May 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants