Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize uniform_binning.py #85

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Conversation

OliviaLynn
Copy link
Member

@OliviaLynn OliviaLynn commented Feb 7, 2024

Problem & Solution Description (including issue #)

Closes issue #84

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c0e32bb) 97.18% compared to head (40802f3) 97.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   97.18%   97.20%   +0.02%     
==========================================
  Files          32       32              
  Lines        1738     1755      +17     
==========================================
+ Hits         1689     1706      +17     
  Misses         49       49              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OliviaLynn OliviaLynn requested a review from drewoldag February 7, 2024 20:17
@OliviaLynn OliviaLynn marked this pull request as ready for review February 7, 2024 21:01
Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good to me.

@OliviaLynn OliviaLynn merged commit 99b6695 into main Feb 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants