Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Per-input evaluator classes #74

Closed
wants to merge 8 commits into from

Conversation

drewoldag
Copy link
Collaborator

WIP PR

Problem & Solution Description (including issue #)

This addresses issue #14
Initial commit is a scaffolding commit for pdf-vs-pdf evaluator, with a goal to use this as a template for the other types of evaluator classes.

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

@drewoldag drewoldag self-assigned this Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd13285) 97.17% compared to head (df3bf80) 97.17%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files          32       32           
  Lines        1736     1736           
=======================================
  Hits         1687     1687           
  Misses         49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eacharles eacharles force-pushed the issue/14/per-input-evaluator branch from 61480e3 to eaaf54d Compare January 10, 2024 18:46
@drewoldag drewoldag requested a review from aimalz February 12, 2024 17:16
@eacharles
Copy link
Collaborator

This has been merged in #98 , closing this PR

@eacharles eacharles closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants