Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actually utils is unused, so remove it #62

Merged
merged 2 commits into from
Oct 26, 2023
Merged

actually utils is unused, so remove it #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0074a28
actually utils is unused, so remove it
eacharles Oct 26, 2023
60456a3
actually, stat_and_pval is included in metrics/cdeloss.py, put it bac…
eacharles Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/rail/evaluation/evaluator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
from rail.core.stage import RailStage
from rail.core.common_params import SHARED_PARAMS

from rail.evaluation.utils import stat_and_pval
from rail.evaluation.metrics.cdeloss import CDELoss
from qp.metrics.pit import PIT
from rail.evaluation.metrics.pointestimates import PointSigmaIQR, PointBias, PointOutlierRate, PointSigmaMAD
Expand Down
2 changes: 1 addition & 1 deletion src/rail/evaluation/metrics/cdeloss.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import numpy as np
from .base import MetricEvaluator
from rail.evaluation.utils import stat_and_pval
from rail.evaluation.stats_groups import stat_and_pval


class CDELoss(MetricEvaluator):
Expand Down
0 src/rail/evaluation/utils.py → src/rail/evaluation/stats_groups.py
View file
Open in desktop
File renamed without changes.
Loading