Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/127/true nz #129

Merged
merged 9 commits into from
Jul 3, 2024
Merged

Issues/127/true nz #129

merged 9 commits into from
Jul 3, 2024

Conversation

eacharles
Copy link
Collaborator

Problem & Solution Description (including issue #)

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

@eacharles
Copy link
Collaborator Author

Still need to add tests.

@eacharles eacharles marked this pull request as ready for review July 2, 2024 16:56
@sschmidt23 sschmidt23 self-requested a review July 2, 2024 23:54
Copy link
Collaborator

@sschmidt23 sschmidt23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, all tests passing

@eacharles eacharles merged commit 0222836 into main Jul 3, 2024
4 checks passed
@eacharles eacharles deleted the issues/127/true_nz branch July 29, 2024 16:33
Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.11%. Comparing base (b0421b6) to head (028e813).
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   98.06%   98.11%   +0.05%     
==========================================
  Files          38       39       +1     
  Lines        2016     2072      +56     
==========================================
+ Hits         1977     2033      +56     
  Misses         39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants