Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up use of chunk_size in var_inf to avoid overwriting config param… #126

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

eacharles
Copy link
Collaborator

…eter

Problem & Solution Description (including issue #)

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

@eacharles eacharles marked this pull request as ready for review June 27, 2024 06:06
@eacharles
Copy link
Collaborator Author

#126

@eacharles eacharles force-pushed the issue/125/var_inf_chunk_size branch from 6080abf to 7eaa6a3 Compare July 3, 2024 15:24
Copy link
Contributor

@ztq1996 ztq1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@eacharles eacharles merged commit e13ea03 into main Jul 19, 2024
4 checks passed
@eacharles eacharles deleted the issue/125/var_inf_chunk_size branch July 29, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants