Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Gather fsps, bpz, and cmnn demos #78

Closed
wants to merge 4 commits into from

Conversation

OliviaLynn
Copy link
Member

@OliviaLynn OliviaLynn commented Oct 3, 2023

Change Description

Gathering external demos as described in #48

See running notes in my comment there.

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c15b902) 100.00% compared to head (99eba5c) 100.00%.
Report is 30 commits behind head on main.

❗ Current head 99eba5c differs from pull request most recent head dd3c81c. Consider uploading reports for the commit dd3c81c to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #78   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sschmidt23
Copy link
Collaborator

For BPZ, having the data at NERSC and just adding a curl command in the notebook seems good to me; however, BPZ_lite does expect the files to be in the SED directory, so we would still need to untar and copy them to the proper directory in the notebook. This is already done in the commented-out commands in the current demo notebook, but I'm mentioning as having them commented out as I currently would cause auto-running of the notebook to fail if rendered as part of automated testing. So, those lines should probably be uncommented when the BPZ_lite_with_custom_SEDs.ipynb notebook is moved.

@OliviaLynn OliviaLynn closed this Oct 17, 2023
@OliviaLynn OliviaLynn deleted the issue/48/gather-demos branch October 24, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants