Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dependencies into rail (from rail_pipelines) #131

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

OliviaLynn
Copy link
Member

@OliviaLynn OliviaLynn commented Apr 17, 2024

Problem & Solution Description (including issue #)

Executes my solution described in this comment in issue #123

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

@OliviaLynn OliviaLynn requested a review from ztq1996 April 17, 2024 20:33
@ztq1996
Copy link
Contributor

ztq1996 commented Apr 17, 2024

Looks good to me. Echoing the message in the Slack channel, I want to wait a little longer for people to raise opinions about adding/removing packages in the installation list. Let’s set the deadline for Monday next week.

@ztq1996 ztq1996 merged commit a417215 into main Apr 23, 2024
5 checks passed
@OliviaLynn OliviaLynn deleted the issue/123/move-deps branch July 8, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants