Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fsps demo; adding fsps set-up to smoke test #118

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

OliviaLynn
Copy link
Member

@OliviaLynn OliviaLynn commented Nov 29, 2023

Problem & Solution Description (including issue #)

Moving in fsps notebook from Eric's branch in fsps

Also adding a step in the smoke test workflow to get fsps set up (required; see this failed run without the set-up step)

Final piece of #48

Code Quality

  • My code follows the code style of this project
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

@OliviaLynn OliviaLynn requested a review from eacharles November 29, 2023 17:38
@OliviaLynn OliviaLynn changed the title Adding fsps demo Adding fsps demo; adding fsps set-up to smoke test Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (26bdfb7) 100.00% compared to head (d31b42f) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #118   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@eacharles eacharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, smoke test ran successfully on this branch. Looks good.

@OliviaLynn OliviaLynn merged commit e015e13 into main Nov 29, 2023
11 checks passed
@OliviaLynn OliviaLynn deleted the issue/48/add_fsps branch November 29, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants