Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update smoke-test.yml to only alert on scheduled runs #114

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

OliviaLynn
Copy link
Member

Problem & Solution Description (including issue #)

Updating the smoke test's "alert slack" step to only trigger on scheduled runs

This lets us manually trigger smoke tests without cluttering the slack

Code Quality

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6194876) 100.00% compared to head (0b659e4) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #114   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OliviaLynn OliviaLynn merged commit a47c55d into main Nov 22, 2023
7 checks passed
@OliviaLynn OliviaLynn deleted the user/olynn/smoke-conditional-alert branch November 22, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants