Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncomment data download/untar commands; update writing to match #113

Merged
merged 4 commits into from
Nov 28, 2023

Conversation

OliviaLynn
Copy link
Member

@OliviaLynn OliviaLynn commented Nov 22, 2023

Problem & Solution Description (including issue #)

#112

Code Quality

  • My code follows the code style of this project
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a47c55d) 100.00% compared to head (315e9f3) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #113   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OliviaLynn OliviaLynn force-pushed the user/olynn/bpz-smoke-data branch from 1fa3fea to 56e8df9 Compare November 22, 2023 21:17
@OliviaLynn OliviaLynn marked this pull request as ready for review November 22, 2023 23:47
Copy link
Collaborator

@sschmidt23 sschmidt23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I put in the single comment, I think it would be better to roll a new rail_base release and remove the separate rail_base install via GitHub. I'll tag a new version of rail_base now.

.github/workflows/smoke-test.yml Outdated Show resolved Hide resolved
@sschmidt23
Copy link
Collaborator

Actually, given that it's hours before Thanksgiving holiday starting and people likely not being around if a new rail_base release would break something, I'll hold off on the new rail_base release.

Copy link
Collaborator

@sschmidt23 sschmidt23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks, feel free to merge once a new rail_base version is created.

@eacharles eacharles merged commit d03fe08 into main Nov 28, 2023
6 checks passed
@OliviaLynn OliviaLynn deleted the user/olynn/bpz-smoke-data branch November 29, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants