-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncomment data download/untar commands; update writing to match #113
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 1 1
=========================================
Hits 1 1 ☔ View full report in Codecov by Sentry. |
1fa3fea
to
56e8df9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I put in the single comment, I think it would be better to roll a new rail_base release and remove the separate rail_base install via GitHub. I'll tag a new version of rail_base now.
Actually, given that it's hours before Thanksgiving holiday starting and people likely not being around if a new rail_base release would break something, I'll hold off on the new rail_base release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks, feel free to merge once a new rail_base version is created.
Problem & Solution Description (including issue #)
#112
Code Quality