-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move in bpz notebooks, update paths; copy over cmnn nb changes #109
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 1 1
=========================================
Hits 1 1 ☔ View full report in Codecov by Sentry. |
653c00c
to
96264f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BPZ_lite_with_custom_SEDs.ipynb
looks good, but BPZ_lite_demo.ipynb
requires one of the files from the tarball that we grab from NERSC. So, I think we need to actually insert a cell in BPZ_lite_demo.ipynb
where the user can uncomment and grab those files. I can do that real quick, at which point I'll approve, but I'll wait on merging until you take a look and check that I've done it all correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I changed some text and added a commented rail get-data
command, so now I think it looks good, I'll approve, if my changes look good go ahead and merge.
Nice catch! That looks great, thank you |
Problem & Solution Description (including issue #)
rail get-data --bpz-demo-data
script in rail_base#76.Also copies over updates to CMNN notebook made in CMNN repo to the notebook here
That was on me, should have deleted it sooner. PR is out to remove it at LSSTDESC/rail_cmnn#13
Code Quality
#pragma: no cover
; in the case of a bugfix, a new test that breaks as a result of the bug has been added