Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added metric factory #209

Merged
merged 6 commits into from
Nov 22, 2023
Merged

Added metric factory #209

merged 6 commits into from
Nov 22, 2023

Conversation

eacharles
Copy link
Collaborator

Problem & Solution Description (including issue #)

Added MetricFactory and associated tests.

Also, added interface functions to src/qp/metrics/init.py

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

@eacharles eacharles requested a review from drewoldag November 21, 2023 19:37
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3fec754) 99.96% compared to head (e489b3b) 99.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #209   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files          36       37    +1     
  Lines        2529     2569   +40     
=======================================
+ Hits         2528     2568   +40     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -53,7 +53,7 @@ def uses_point_for_reference(self) -> bool:
]


class MetricOuputType(enum.Enum):
class MetricOutputType(enum.Enum):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 <- I'm glad there's a facepalm emoji in slack.

Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fine to me. Thanks for putting this together.

@eacharles eacharles force-pushed the issue/208/metric_factory branch from 8cda83f to 791da31 Compare November 21, 2023 23:55
@eacharles eacharles merged commit 8386258 into main Nov 22, 2023
6 checks passed
@eacharles eacharles deleted the issue/208/metric_factory branch May 28, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants