-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added metric factory #209
Added metric factory #209
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 36 37 +1
Lines 2529 2569 +40
=======================================
+ Hits 2528 2568 +40
Misses 1 1 ☔ View full report in Codecov by Sentry. |
@@ -53,7 +53,7 @@ def uses_point_for_reference(self) -> bool: | |||
] | |||
|
|||
|
|||
class MetricOuputType(enum.Enum): | |||
class MetricOutputType(enum.Enum): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦 <- I'm glad there's a facepalm emoji in slack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks fine to me. Thanks for putting this together.
8cda83f
to
791da31
Compare
Problem & Solution Description (including issue #)
Added MetricFactory and associated tests.
Also, added interface functions to src/qp/metrics/init.py
Code Quality
#pragma: no cover
; in the case of a bugfix, a new test that breaks as a result of the bug has been added