Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/204/is qp file #205

Merged
merged 5 commits into from
Nov 8, 2023
Merged

Issue/204/is qp file #205

merged 5 commits into from
Nov 8, 2023

Conversation

eacharles
Copy link
Collaborator

Problem & Solution Description (including issue #)

Address #204

Code Quality

  • [ x] My code follows the code style of this project
  • [ x] I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c0dcfe) 99.95% compared to head (0459f06) 99.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #205   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files          33       33           
  Lines        2286     2294    +8     
=======================================
+ Hits         2285     2293    +8     
  Misses          1        1           
Files Coverage Δ
src/qp/__init__.py 100.00% <100.00%> (ø)
src/qp/factory.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eacharles eacharles requested a review from drewoldag November 8, 2023 19:39
Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok.

@eacharles eacharles merged commit a578c66 into main Nov 8, 2023
6 checks passed
drewoldag pushed a commit that referenced this pull request Nov 8, 2023
* added is_qp_file function

* added is_qp_file function

* added inline comments

* added print statement about exception

* fix up temp file
@eacharles eacharles deleted the issue/204/is_qp_file branch May 28, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants