attempt to use copier template #197
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 34 33 -1
Lines 2284 2279 -5
=========================================
- Hits 2284 2279 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Hi Drew, Melissa, I pulled this to use the RAIL packages template. I had to make a few minor changes to get that to work, mainly adding a line to install MPI and changing where it looks for the code (qp instead of rail), but I see a lot of value in using the same github actions as all the RAIL packages. Thoughts? |
|
Yep, totally on board with using a relatively consistent set of CI actions. Looking over the PR now. |
| # Changes here will be overwritten by Copier | ||
| _commit: v0.2 | ||
| _src_path: gh:LSSTDESC/RAIL-project-template | ||
| author_email: [email protected] |
There was a problem hiding this comment.
There was a problem hiding this comment.
Where does that actually end up?
There was a problem hiding this comment.
I'm pretty sure that the author_email is only used to populate the corresponding field in the pyproject.toml file.
There was a problem hiding this comment.
I left a comment in the pyproject.toml file pointing out where it's used. And if you want to up update it, it should be safe to do so without running copier update again as long as you change it in both .copier-answers.yml and pyproject.toml.
| license = {file = "LICENSE"} | ||
| readme = "README.md" | ||
|
|
||
| authors = [ | ||
| { name = "LSST Dark Energy Science Collaboration (DESC)", email = "[email protected]" } |
There was a problem hiding this comment.
This is where [email protected] ended up. It's not considered best practice, but since author_email is only used in one location, you can update it here and in the .copier-answeres.yml file and avoid having to run copier update again.
|
I’m not sure what email address to use. Is there a way to set up a group on GitHub & use that?On Oct 24, 2023, at 9:42 AM, Drew Oldag ***@***.***> wrote:
@drewoldag commented on this pull request.
In .copier-answers.yml:
@@ -0,0 +1,8 @@
+# Changes here will be overwritten by Copier
+_commit: v0.2
+_src_path: gh:LSSTDESC/RAIL-project-template
+author_email: ***@***.***
I left a comment in the pyproject.toml file pointing out where it's used. And if you want to up update it, it should be safe to do so without running copier update again as long as you change it in both .copier-answers.yml and pyproject.toml.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
No description provided.