Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

old_location checks #158

Merged
merged 1 commit into from
Oct 31, 2024
Merged

old_location checks #158

merged 1 commit into from
Oct 31, 2024

Conversation

stuartmcalpine
Copy link
Collaborator

  • Make sure relative_path is specified if old_location is None and the location_type=dataregistry

@stuartmcalpine stuartmcalpine mentioned this pull request Oct 18, 2024
Open
JoanneBogart
JoanneBogart approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@JoanneBogart JoanneBogart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmcalpine stuartmcalpine merged commit 5d592d0 into main Oct 31, 2024
26 checks passed
@stuartmcalpine stuartmcalpine deleted the u/stuart/old_location_checks branch October 31, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanneBogart JoanneBogart JoanneBogart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuartmcalpine @JoanneBogart